[prev in list] [next in list] [prev in thread] [next in thread]
List: openser-devel
Subject: Re: [sr-dev] [kamailio/kamailio] sipt: Add functions to work with forwarding info (#1498)
From: Sergey Basov <notifications () github ! com>
Date: 2018-04-26 5:26:19
Message-ID: kamailio/kamailio/pull/1498/c384517610 () github ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Daniel,
I will try to do this.
--
Best regards,
Sergey Basov e-mail: sergey.v.basov@gmail.com
2018-04-25 15:57 GMT+03:00 Daniel-Constantin Mierla <
notifications@github.com>:
> @sergey-vb <https://github.com/sergey-vb> - would you consider having the
> new variables as part of $sipt(...)?
>
> So instead of:
>
> $sipt_redirection_info
> $sipt_redirection_number_nai
> $sipt_redirection_number
>
> To have:
>
> $sipt(redirection_info)
> $sipt(redirection_number_nai)
> $sipt(redirection_number)
>
> I think it is better to have them grouped. You can push a new patch for
> it, no need to do a new PR. Then I can merge.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/kamailio/kamailio/pull/1498#issuecomment-384276779>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ARTPaxobYA4a77iPiq1jMOCs67E4hwKkks5tsHKjgaJpZM4TR8HV>
>
> .
>
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1498#issuecomment-384517610
[Attachment #5 (text/html)]
Hi Daniel,<br>
I will try to do this.<br>
<br>
--<br>
Best regards,<br>
Sergey Basov e-mail: sergey.v.basov@gmail.com<br>
<br>
2018-04-25 15:57 GMT+03:00 Daniel-Constantin Mierla <<br>
notifications@github.com>:<br>
<br>
> @sergey-vb <https://github.com/sergey-vb> - would you consider having \
the<br> > new variables as part of $sipt(...)?<br>
><br>
> So instead of:<br>
><br>
> $sipt_redirection_info<br>
> $sipt_redirection_number_nai<br>
> $sipt_redirection_number<br>
><br>
> To have:<br>
><br>
> $sipt(redirection_info)<br>
> $sipt(redirection_number_nai)<br>
> $sipt(redirection_number)<br>
><br>
> I think it is better to have them grouped. You can push a new patch for<br>
> it, no need to do a new PR. Then I can merge.<br>
><br>
> —<br>
> You are receiving this because you were mentioned.<br>
> Reply to this email directly, view it on GitHub<br>
> <https://github.com/kamailio/kamailio/pull/1498#issuecomment-384276779>,<br>
> or mute the thread<br>
> <https://github.com/notifications/unsubscribe-auth/ARTPaxobYA4a77iPiq1jMOCs67E4hwKkks5tsHKjgaJpZM4TR8HV><br>
> .<br>
><br>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You \
are receiving this because you are subscribed to this thread.<br />Reply to this \
email directly, <a href="https://github.com/kamailio/kamailio/pull/1498#issuecomment-384517610">view \
it on GitHub</a>, or <a \
href="https://github.com/notifications/unsubscribe-auth/AF36ZeeBZTD2o6pT0LWX8wa40_CL7J1Bks5tsVp7gaJpZM4TR8HV">mute \
the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZUDgVI8-hPBapocxKJwEl7LL-5_mks5tsVp7gaJpZM4TR8HV.gif" \
height="1" width="1" alt="" /></p> <div itemscope \
itemtype="http://schema.org/EmailMessage"> <div itemprop="action" itemscope \
itemtype="http://schema.org/ViewAction"> <link itemprop="url" \
href="https://github.com/kamailio/kamailio/pull/1498#issuecomment-384517610"></link> \
<meta itemprop="name" content="View Pull Request"></meta> </div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" \
data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384d \
d78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub \
repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/174958 \
39/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubu \
sercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open \
in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sergey-vb \
in #1498: Hi Daniel,\nI will try to do this.\n\n--\nBest regards,\nSergey Basov \
e-mail: sergey.v.basov@gmail.com\n\n2018-04-25 15:57 GMT+03:00 Daniel-Constantin \
Mierla \u003c\nnotifications@github.com\u003e:\n\n\u003e @sergey-vb \
\u003chttps://github.com/sergey-vb\u003e - would you consider having the\n\u003e new \
variables as part of $sipt(...)?\n\u003e\n\u003e So instead of:\n\u003e\n\u003e \
$sipt_redirection_info\n\u003e $sipt_redirection_number_nai\n\u003e \
$sipt_redirection_number\n\u003e\n\u003e To have:\n\u003e\n\u003e \
$sipt(redirection_info)\n\u003e $sipt(redirection_number_nai)\n\u003e \
$sipt(redirection_number)\n\u003e\n\u003e I think it is better to have them grouped. \
You can push a new patch for\n\u003e it, no need to do a new PR. Then I can \
merge.\n\u003e\n\u003e —\n\u003e You are receiving this because you were \
mentioned.\n\u003e Reply to this email directly, view it on GitHub\n\u003e \
\u003chttps://github.com/kamailio/kamailio/pull/1498#issuecomment-384276779\u003e,\n\u003e \
or mute the thread\n\u003e \
\u003chttps://github.com/notifications/unsubscribe-auth/ARTPaxobYA4a77iPiq1jMOCs67E4hwKkks5tsHKjgaJpZM4TR8HV\u003e\n\u003e \
.\n\u003e\n"}],"action":{"name":"View Pull \
Request","url":"https://github.com/kamailio/kamailio/pull/1498#issuecomment-384517610"}}}</script>
[Attachment #6 (text/plain)]
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic