[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openser-devel
Subject:    [sr-dev] git:master:261a3464: Merge pull request #222 from mslehto/tautological-compare
From:       Daniel-Constantin Mierla <miconda () gmail ! com>
Date:       2015-06-25 9:58:25
Message-ID: E1Z83vN-0003AH-U5 () www ! kamailio ! org
[Download RAW message or body]

Module: kamailio
Branch: master
Commit: 261a3464f0a65dcf0de5458eff50aa4b9f64964c
URL: https://github.com/kamailio/kamailio/commit/261a3464f0a65dcf0de5458eff50aa4b9f64964c

Author: Daniel-Constantin Mierla <miconda@gmail.com>
Committer: Daniel-Constantin Mierla <miconda@gmail.com>
Date: 2015-06-25T11:58:20+02:00

Merge pull request #222 from mslehto/tautological-compare

modules/[rls|presence_xml]: fixes warning [-Wtautological-compare]

---

Modified: modules/presence_xml/presence_xml.c
Modified: modules/rls/rls.c

---

Diff:  https://github.com/kamailio/kamailio/commit/261a3464f0a65dcf0de5458eff50aa4b9f64964c.diff
Patch: https://github.com/kamailio/kamailio/commit/261a3464f0a65dcf0de5458eff50aa4b9f64964c.patch

---

diff --git a/modules/presence_xml/presence_xml.c b/modules/presence_xml/presence_xml.c
index 29bf3ec..f8781ef 100644
--- a/modules/presence_xml/presence_xml.c
+++ b/modules/presence_xml/presence_xml.c
@@ -382,7 +382,7 @@ static int pxml_add_xcap_server( modparam_t type, void* val)
 			LM_ERR("while converting string to int\n");
 			goto error;
 		}
-		if(port< 0 || port> 65535)
+		if(port< 1 || port> 65535)
 		{
 			LM_ERR("wrong port number\n");
 			goto error;
diff --git a/modules/rls/rls.c b/modules/rls/rls.c
index 23c6a7c..26d9be0 100644
--- a/modules/rls/rls.c
+++ b/modules/rls/rls.c
@@ -333,7 +333,7 @@ static int mod_init(void)
 					port_str.len, port_str.s);
 				return -1;
 			}
-			if(xcap_port< 0 || xcap_port> 65535)
+			if(xcap_port< 1 || xcap_port> 65535)
 			{
 				LM_ERR("wrong xcap server port\n");
 				return -1;


_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
[prev in list] [next in list] [prev in thread] [next in thread]