[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openser-devel
Subject:    [sr-dev] git:master: modules_k/pua: Fixed occasional seg fault in PUA
From:       Peter Dunkley <peter.dunkley () crocodile-rcs ! com>
Date:       2012-01-30 11:32:22
Message-ID: 20120130113222.D9768EF804D () rimmer ! ryngle ! com
[Download RAW message or body]

Module: sip-router
Branch: master
Commit: 6d30bd740303677711de437c4a3fec15da7344a8
URL:    http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6d30bd740303677711de437c4a3fec15da7344a8


Author: pd <peter.dunkley@crocodile-rcs.com>
Committer: pd <peter.dunkley@crocodile-rcs.com>
Date:   Mon Jan 30 11:28:59 2012 +0000

modules_k/pua: Fixed occasional seg fault in PUA

- This was added by the fix to the race hazards
  (Commit ID: e627bc31776b521a1078b2a004e8ed179521cae2)
- It only happens in certain error situations (which should not occur anyway -
  these are under investigation now) and was found during an over-weekend
  soak test.
- Found and fixed by Paul Pankhurst @ Crocodile RCS

---

 modules_k/pua/send_subscribe.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/modules_k/pua/send_subscribe.c b/modules_k/pua/send_subscribe.c
index 7c25bc7..396ac90 100644
--- a/modules_k/pua/send_subscribe.c
+++ b/modules_k/pua/send_subscribe.c
@@ -696,8 +696,11 @@ done:
 	goto end;
 
 error:	
-	if (presentity->remote_contact.s) shm_free(presentity->remote_contact.s);
-	if (presentity) shm_free(presentity);
+        if (presentity)
+	{
+		if (presentity->remote_contact.s) shm_free(presentity->remote_contact.s);
+	 	shm_free(presentity);
+	}
 
 end:
 


_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev


[prev in list] [next in list] [prev in thread] [next in thread]