[prev in list] [next in list] [prev in thread] [next in thread] 

List:       opensc-commits
Subject:    [Opensc-commits] [OpenSC/OpenSC] 0a6c1c: Make OpenPGP card user/signature PIN order match P...
From:       GitHub <noreply () github ! com>
Date:       2016-09-20 12:48:22
Message-ID: 57e1301623351_68223faa7db7714c98529 () hookshot-fe4-cp1-prd ! iad ! github ! net ! mail
[Download RAW message or body]

Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 0a6c1c4fb3fee9b27cd71fd97e7e8b40a880286d
      https://github.com/OpenSC/OpenSC/commit/0a6c1c4fb3fee9b27cd71fd97e7e8b40a880286d
  Author: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
  Date:   2016-08-30 (Tue, 30 Aug 2016)

  Changed paths:
    M src/libopensc/pkcs15-openpgp.c

  Log Message:
  -----------
  Make OpenPGP card user/signature PIN order match PKCS#11 framework

_get_auth_object_by_name() in pkcs11/framework-pkcs15.c needs user PIN
to be the first one and then next one can be signature PIN, but OpenPGP
card had it reversed.

Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>


  Commit: 3e3528bb687500a071e8c2b9bf53328b491e6467
      https://github.com/OpenSC/OpenSC/commit/3e3528bb687500a071e8c2b9bf53328b491e6467
  Author: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
  Date:   2016-08-30 (Tue, 30 Aug 2016)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP card doesn't support raw RSA so don't set such algo flag

According to descriptions of commands "PSO: COMPUTE DIGITAL SIGNATURE",
"PSO: DECIPHER" and "INTERNAL AUTHENTICATE" in OpenPGP card spec (versions
1.1 and 2.1.1) the card adds / strips and checks PKCS#1 padding
automatically.
There is no documented way to perform raw RSA operations on this card so
SC_ALGORITHM_RSA_RAW flag shouldn't be set.

Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>


  Commit: 80f5c8b835c89a869d67fe13d0e55c5905adcee2
      https://github.com/OpenSC/OpenSC/commit/80f5c8b835c89a869d67fe13d0e55c5905adcee2
  Author: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
  Date:   2016-08-30 (Tue, 30 Aug 2016)

  Changed paths:
    M src/libopensc/card-entersafe.c
    M src/pkcs15init/pkcs15-openpgp.c

  Log Message:
  -----------
  Code files don't need execute permission

Some .c files had execute permission bit set needlessly.

Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>


  Commit: dc476a9f3313a0aab4ea09220a8763765fe639f2
      https://github.com/OpenSC/OpenSC/commit/dc476a9f3313a0aab4ea09220a8763765fe639f2
  Author: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
  Date:   2016-08-30 (Tue, 30 Aug 2016)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  Improve handling of OpenPGP card PIN change and unblock commands

"CHANGE REFERENCE DATA" (PIN change) and "RESET RETRY COUNTER"
(PIN unblock) commands in OpenPGP card have various limitations.
These also depend on whether the card is version 1.x or 2.x.

Provide helpful debug messages for user in case he is trying to do
a PIN command in a way that isn't supported by the card.

Also, take into account that version 2.x cards don't support references to
PW1-mode 2 (82) in these commands - change them to PW1 (81).

Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>


  Commit: 8d67adb06c7d868f2c02414c3b90fe0edbdb9ba1
      https://github.com/OpenSC/OpenSC/commit/8d67adb06c7d868f2c02414c3b90fe0edbdb9ba1
  Author: Frank Morgner <frankmorgner@gmail.com>
  Date:   2016-09-20 (Tue, 20 Sep 2016)

  Changed paths:
    M src/libopensc/card-entersafe.c
    M src/libopensc/card-openpgp.c
    M src/libopensc/pkcs15-openpgp.c
    M src/pkcs15init/pkcs15-openpgp.c

  Log Message:
  -----------
  Merge pull request #864 from maciejsszmigiero/openpgp-fixes-small

OpenPGP card small fixes


Compare: https://github.com/OpenSC/OpenSC/compare/d42aab11ab97...8d67adb06c7d

------------------------------------------------------------------------------


_______________________________________________
Opensc-commits mailing list
Opensc-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensc-commits


[prev in list] [next in list] [prev in thread] [next in thread]