[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openocd-development
Subject:    [PATCH]: ce28efb008 src/server: memory leak of reg_list
From:       gerrit () openocd ! org
Date:       2023-03-31 15:14:29
Message-ID: 20230331151429.A1EDBE9 () openocd ! org
[Download RAW message or body]

This is an automated email from Gerrit.

"Name of user not set <panciyan@eswincomputing.com>" just uploaded a new patch set to \
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/7566

-- gerrit

commit ce28efb00813e9cf395013d4983538af3d72c3d5
Author: panciyan <panciyan@eswincomputing.com>
Date:   Fri Mar 31 15:12:08 2023 +0000

    src/server: memory leak of reg_list
    
    memory leak of reg_list when local_list realloc fail.
    
    Signed-off-by: panciyan <panciyan@eswincomputing.com>
    Change-Id: I6b09137ecd132ab326205f5a575a38bcc82e8469

diff --git a/src/server/gdb_server.c b/src/server/gdb_server.c
index d8dbc2c8b7..b15a6c1c3b 100644
--- a/src/server/gdb_server.c
+++ b/src/server/gdb_server.c
@@ -2348,6 +2348,7 @@ static int smp_reg_list_noread(struct target *target,
 						local_list = realloc(local_list, combined_allocated * sizeof(struct reg *));
 						if (!local_list) {
 							LOG_ERROR("realloc(%zu) failed", combined_allocated * sizeof(struct reg *));
+							free(reg_list);
 							return ERROR_FAIL;
 						}
 					}

-- 


[prev in list] [next in list] [prev in thread] [next in thread]