[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openocd-development
Subject:    [PATCH]: 7ea1b19711 target/xtensa: fix step state transition
From:       gerrit () openocd ! org
Date:       2022-08-29 17:21:23
Message-ID: 20220829172123.F095DED () openocd ! org
[Download RAW message or body]

This is an automated email from Gerrit.

"Ian Thompson <ianst@cadence.com>" just uploaded a new patch set to Gerrit, which you \
can find at https://review.openocd.org/c/openocd/+/7150

-- gerrit

commit 7ea1b197112d0d5605f59243c349ac6bb96aacc1
Author: Ian Thompson <ianst@cadence.com>
Date:   Mon Aug 29 07:34:18 2022 -0700

    target/xtensa: fix step state transition
    
    For some configurations, notably on DAP systems, resolve issue where \
single-stepping does not always transition into the HALTED state.  
    Signed-off-by: Ian Thompson <ianst@cadence.com>
    Change-Id: I053f4eaffad8c3228878ba87580ada640e4bd2fe

diff --git a/src/target/xtensa/xtensa.c b/src/target/xtensa/xtensa.c
index 2fd2c7ca57..cee0174c1b 100644
--- a/src/target/xtensa/xtensa.c
+++ b/src/target/xtensa/xtensa.c
@@ -1646,7 +1646,11 @@ int xtensa_do_step(struct target *target, int current, \
target_addr_t address, in  
 int xtensa_step(struct target *target, int current, target_addr_t address, int \
handle_breakpoints)  {
-	return xtensa_do_step(target, current, address, handle_breakpoints);
+	int retval = xtensa_do_step(target, current, address, handle_breakpoints);
+	if (retval != ERROR_OK)
+		return retval;
+	target_call_event_callbacks(target, TARGET_EVENT_HALTED);
+	return retval;
 }
 
 /**

-- 


[prev in list] [next in list] [prev in thread] [next in thread]