[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openocd-development
Subject:    [PATCH]: e703669aa flash/stm32l4x: fix some scan-build warnings
From:       gerrit () openocd ! org
Date:       2021-08-24 10:23:46
Message-ID: 20210824102346.7F015288 () openocd ! org
[Download RAW message or body]

This is an automated email from Gerrit.

"Tarek BOCHKATI <tarek.bouchkati@gmail.com>" just uploaded a new patch set to Gerrit, \
which you can find at https://review.openocd.org/c/openocd/+/6470

-- gerrit

commit e703669aa81018ffae556a03401f61528111fd3f
Author: Tarek BOCHKATI <tarek.bouchkati@gmail.com>
Date:   Tue Aug 24 11:15:09 2021 +0100

    flash/stm32l4x: fix some scan-build warnings
    
    fix "Declared variable-length array (VLA) has zero size" warnings
    
    Change-Id: I3ba0e6345881557ad1aab2d1b41eee438b49fe04
    Signed-off-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>

diff --git a/src/flash/nor/stm32l4x.c b/src/flash/nor/stm32l4x.c
index d770cdfa5..942d15047 100644
--- a/src/flash/nor/stm32l4x.c
+++ b/src/flash/nor/stm32l4x.c
@@ -1076,6 +1076,11 @@ static int stm32l4_protect(struct flash_bank *bank, int set, \
unsigned int first,  return ret;
 
 	/* use bitmap and range helpers to optimize the WRP usage */
+
+	/* this should never happen, silence a scan-build warning */
+	if (!bank->num_sectors)
+		return ERROR_FAIL;
+
 	DECLARE_BITMAP(pages, bank->num_sectors);
 	bitmap_zero(pages, bank->num_sectors);
 
@@ -1920,6 +1925,7 @@ COMMAND_HANDLER(stm32l4_handle_wrp_info_command)
 	struct stm32l4_wrp wrpxy[4];
 
 	ret = stm32l4_get_all_wrpxy(bank, dev_bank_id, wrpxy, &n_wrp);
+	ret = n_wrp ? ret : ERROR_FAIL;
 	if (ret != ERROR_OK)
 		return ret;
 

-- 


[prev in list] [next in list] [prev in thread] [next in thread]