[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openocd-development
Subject:    [OpenOCD-devel] [PATCH]: e1031ea cortex_m: declare local functions as static
From:       gerrit () openocd ! org (gerrit)
Date:       2020-10-29 11:34:36
Message-ID: 20201029113436.343BA4A0215 () mail ! openocd ! org
[Download RAW message or body]

This is an automated email from Gerrit.

Antonio Borneo (borneo.antonio@gmail.com) just uploaded a new patch set to Gerrit, \
which you can find at http://openocd.zylin.com/5900

-- gerrit

commit e1031eab86caf5890dfaf7df74ec119c2cb4a3cd
Author: Antonio Borneo <borneo.antonio@gmail.com>
Date:   Wed Oct 28 23:48:57 2020 +0100

    cortex_m: declare local functions as static
    
    Functions that are not used outside the file should be declared as
    static.
    
    Change-Id: Ie81f6bdce91e2a1456364b47f30aa4d35c7ee7bc
    Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>

diff --git a/src/target/cortex_m.c b/src/target/cortex_m.c
index abc377f..b869fb7 100644
--- a/src/target/cortex_m.c
+++ b/src/target/cortex_m.c
@@ -1413,7 +1413,7 @@ int cortex_m_remove_breakpoint(struct target *target, struct \
breakpoint *breakpo  return cortex_m_unset_breakpoint(target, breakpoint);
 }
 
-int cortex_m_set_watchpoint(struct target *target, struct watchpoint *watchpoint)
+static int cortex_m_set_watchpoint(struct target *target, struct watchpoint \
*watchpoint)  {
 	int dwt_num = 0;
 	struct cortex_m_common *cortex_m = target_to_cm(target);
@@ -1496,7 +1496,7 @@ int cortex_m_set_watchpoint(struct target *target, struct \
watchpoint *watchpoint  return ERROR_OK;
 }
 
-int cortex_m_unset_watchpoint(struct target *target, struct watchpoint *watchpoint)
+static int cortex_m_unset_watchpoint(struct target *target, struct watchpoint \
*watchpoint)  {
 	struct cortex_m_common *cortex_m = target_to_cm(target);
 	struct cortex_m_dwt_comparator *comparator;
@@ -2013,7 +2013,7 @@ static void cortex_m_dwt_addreg(struct target *t, struct reg \
*r, const struct dw  r->type = &dwt_reg_type;
 }
 
-void cortex_m_dwt_setup(struct cortex_m_common *cm, struct target *target)
+static void cortex_m_dwt_setup(struct cortex_m_common *cm, struct target *target)
 {
 	uint32_t dwtcr;
 	struct reg_cache *cache;
diff --git a/src/target/cortex_m.h b/src/target/cortex_m.h
index 415a6c2..b470fbd 100644
--- a/src/target/cortex_m.h
+++ b/src/target/cortex_m.h
@@ -233,13 +233,10 @@ int cortex_m_set_breakpoint(struct target *target, struct \
breakpoint *breakpoint  int cortex_m_unset_breakpoint(struct target *target, struct \
breakpoint *breakpoint);  int cortex_m_add_breakpoint(struct target *target, struct \
breakpoint *breakpoint);  int cortex_m_remove_breakpoint(struct target *target, \
                struct breakpoint *breakpoint);
-int cortex_m_set_watchpoint(struct target *target, struct watchpoint *watchpoint);
-int cortex_m_unset_watchpoint(struct target *target, struct watchpoint *watchpoint);
 int cortex_m_add_watchpoint(struct target *target, struct watchpoint *watchpoint);
 int cortex_m_remove_watchpoint(struct target *target, struct watchpoint \
*watchpoint);  void cortex_m_enable_breakpoints(struct target *target);
 void cortex_m_enable_watchpoints(struct target *target);
-void cortex_m_dwt_setup(struct cortex_m_common *cm, struct target *target);
 void cortex_m_deinit_target(struct target *target);
 int cortex_m_profiling(struct target *target, uint32_t *samples,
 	uint32_t max_num_samples, uint32_t *num_samples, uint32_t seconds);

-- 


_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel


[prev in list] [next in list] [prev in thread] [next in thread]