[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openocd-development
Subject:    [OpenOCD-devel] [PATCH]: 5e02dd9 target: fix registers reading from not examined target
From:       gerrit () openocd ! org (gerrit)
Date:       2020-06-27 20:52:17
Message-ID: 20200627205217.70FEC4A0CE4 () mail ! openocd ! org
[Download RAW message or body]

This is an automated email from Gerrit.

Mikhail Rasputin (mikhail.godlike.rasputin@yandex.ru) just uploaded a new patch set \
to Gerrit, which you can find at http://openocd.zylin.com/5727

-- gerrit

commit 5e02dd9e1165ccf87c145ff9efc8b4380de5d547
Author: Mikhail Rasputin <mikhail.godlike.rasputin@yandex.ru>
Date:   Sat Jun 27 23:30:42 2020 +0300

    target: fix registers reading from not examined target
    
    If a target is not examined when the debugger tries to connect to it
    then it can lead to undesired/undefined behavior.
    
    In particular it leads to a zero pointer dereference on the aarch64.
    
    
    Change-Id: I67f2b714ab8b2727fd36f3de16d7f9017b4c55fe
    Signed-off-by: Mikhail Rasputin <mikhail.godlike.rasputin@yandex.ru>

diff --git a/src/target/target.c b/src/target/target.c
index 2ea1e20..793e71a 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -1224,8 +1224,17 @@ int target_get_gdb_reg_list(struct target *target,
 		struct reg **reg_list[], int *reg_list_size,
 		enum target_register_class reg_class)
 {
-	int result = target->type->get_gdb_reg_list(target, reg_list,
+	int result = ERROR_FAIL;
+
+	if (!target_was_examined(target)) {
+		LOG_ERROR("Target not examined yet");
+		goto done;
+	}
+
+	result = target->type->get_gdb_reg_list(target, reg_list,
 			reg_list_size, reg_class);
+
+done:
 	if (result != ERROR_OK) {
 		*reg_list = NULL;
 		*reg_list_size = 0;

-- 


_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel


[prev in list] [next in list] [prev in thread] [next in thread]