[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openocd-development
Subject:    [OpenOCD-devel] [PATCH]: b736da3 coding style: fix multi-line dereferencing
From:       gerrit () openocd ! org (gerrit)
Date:       2020-04-27 15:59:24
Message-ID: 20200427155924.DBDCE4A0AEB () mail ! openocd ! org
[Download RAW message or body]

This is an automated email from Gerrit.

Antonio Borneo (borneo.antonio@gmail.com) just uploaded a new patch set to Gerrit, \
which you can find at http://openocd.zylin.com/5629

-- gerrit

commit b736da32400638fda6ada47a6ef39830d8f47e3f
Author: Antonio Borneo <borneo.antonio@gmail.com>
Date:   Mon May 6 19:31:00 2019 +0200

    coding style: fix multi-line dereferencing
    
    Issue identified by checkpatch script from Linux kernel v5.1 using
    the command
    
    	find src/ -type f -exec ./tools/scripts/checkpatch.pl \
    	-q --types MULTILINE_DEREFERENCE -f {} \;
    
    Change-Id: Icba05613e22a72ecc3e6a0aad7cb6b479496146f
    Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>

diff --git a/src/rtos/linux.c b/src/rtos/linux.c
index e85a3bd..63659bb 100644
--- a/src/rtos/linux.c
+++ b/src/rtos/linux.c
@@ -995,10 +995,8 @@ static int linux_task_update(struct target *target, int context)
 					if (context)
 						thread_list->context =
 							cpu_context_read(target,
-								thread_list->
-								base_addr,
-								&thread_list->
-								thread_info_addr);
+								thread_list->base_addr,
+								&thread_list->thread_info_addr);
 				} else {
 					/*  it is a current thread no need to read context */
 				}
@@ -1190,9 +1188,8 @@ int linux_gdb_T_packet(struct connection *connection,
 				} else {
 					/* delete item in the list   */
 					linux_os->thread_list =
-						liste_del_task(linux_os->
-							thread_list, &temp,
-							prev);
+						liste_del_task(linux_os->thread_list,
+							&temp, prev);
 					linux_os->thread_count--;
 					gdb_put_packet(connection, "E01", 3);
 					return ERROR_OK;
@@ -1323,9 +1320,7 @@ static int linux_thread_packet(struct connection *connection, \
char const *packet  if (strncmp(packet, "qSymbol", 7) == 0) {
 				if (rtos_qsymbol(connection, packet, packet_size) == 1) {
 					linux_compute_virt2phys(target,
-							target->rtos->
-							symbols[INIT_TASK].
-							address);
+							target->rtos->symbols[INIT_TASK].address);
 				}
 
 				break;
@@ -1376,8 +1371,7 @@ static int linux_thread_packet(struct connection *connection, \
char const *packet  }
 
 				if ((ct != NULL) && (ct->threadid !=
-						 target->rtos->
-						 current_threadid)
+						 target->rtos->current_threadid)
 				&& (target->rtos->current_threadid != -1))
 					LOG_WARNING("WARNING! current GDB thread do not match "
 							"current thread running. "
@@ -1410,8 +1404,7 @@ static int linux_os_smp_init(struct target *target)
 	while (head != (struct target_list *)NULL) {
 		if (head->target->rtos != rtos) {
 			struct linux_os *smp_os_linux =
-				(struct linux_os *)head->target->rtos->
-				rtos_specific_params;
+				(struct linux_os *)head->target->rtos->rtos_specific_params;
 			/*  remap smp target on rtos  */
 			free(head->target->rtos);
 			head->target->rtos = rtos;
diff --git a/src/server/telnet_server.c b/src/server/telnet_server.c
index a864f5f..be5e108 100644
--- a/src/server/telnet_server.c
+++ b/src/server/telnet_server.c
@@ -411,8 +411,8 @@ static int telnet_input(struct connection *connection)
 								for (i = 1; i < TELNET_LINE_HISTORY_SIZE; i++) {
 									/* the t_con->next_history line contains empty string
 									 * (unless NULL), thus it is not printed */
-									char *history_line = t_con->history[(t_con->
-											next_history + i) %
+									char *history_line =
+											t_con->history[(t_con->next_history + i) %
 											TELNET_LINE_HISTORY_SIZE];
 									if (history_line) {
 										telnet_write(connection, history_line,
diff --git a/src/target/etm.c b/src/target/etm.c
index 5218a9e..5d079ff 100644
--- a/src/target/etm.c
+++ b/src/target/etm.c
@@ -1074,8 +1074,8 @@ static int etmv1_analyze_trace(struct etm_context *ctx, struct \
command_invocatio  (instruction.type == ARM_STM)) {
 					int i;
 					for (i = 0; i < 16; i++) {
-						if (instruction.info.load_store_multiple.
-							register_list & (1 << i)) {
+						if (instruction.info.load_store_multiple.register_list
+							& (1 << i)) {
 							uint32_t data;
 							if (etmv1_data(ctx, 4, &data) != 0)
 								return ERROR_ETM_ANALYSIS_FAILED;

-- 


_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel


[prev in list] [next in list] [prev in thread] [next in thread]