[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openocd-development
Subject:    [OpenOCD-devel] [PATCH]: f11daba src/jtag/aice: Fix obviously incorrect bit op.
From:       gerrit () openocd ! org (gerrit)
Date:       2019-09-12 16:25:10
Message-ID: 20190912162510.49D372522570 () mail ! openocd ! org
[Download RAW message or body]

This is an automated email from Gerrit.

Seth LaForge (sethml@google.com) just uploaded a new patch set to Gerrit, which you \
can find at http://openocd.zylin.com/5301

-- gerrit

commit f11daba3b1c57a864fd7f8a72c593dfccc3611d4
Author: Seth LaForge <sethml@google.com>
Date:   Thu Sep 12 09:18:45 2019 -0700

    src/jtag/aice: Fix obviously incorrect bit op.
    
    Fix expression "(pin_status | 0x4)" which was always true rather than
    testing a bit. Untested - was clearly not expressing the intent of the
    author by inspection. Found by automated tooling and rtrieu@google.com.
    
    Signed-off-by: Seth LaForge <sethml@google.com>
    Change-Id: I4bb91e60e8ce9757bf21976cc48de6f85a39c68d

diff --git a/src/jtag/aice/aice_usb.c b/src/jtag/aice/aice_usb.c
index af08ace..324ec7c 100644
--- a/src/jtag/aice/aice_usb.c
+++ b/src/jtag/aice/aice_usb.c
@@ -2812,7 +2812,7 @@ static int aice_issue_reset_hold(uint32_t coreid)
 	/* set no_dbgi_pin to 0 */
 	uint32_t pin_status;
 	aice_read_ctrl(AICE_READ_CTRL_GET_JTAG_PIN_STATUS, &pin_status);
-	if (pin_status | 0x4)
+	if (pin_status & 0x4)
 		aice_write_ctrl(AICE_WRITE_CTRL_JTAG_PIN_STATUS, pin_status & (~0x4));
 
 	/* issue restart */

-- 


_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel


[prev in list] [next in list] [prev in thread] [next in thread]