[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openocd-development
Subject:    Re: [OpenOCD-devel] Problem with zylin
From:       Andreas_Färber <afaerber () suse ! de>
Date:       2017-03-16 6:47:35
Message-ID: 0f5f0a08-b840-0e3f-c173-49f474ae9013 () suse ! de
[Download RAW message or body]

Hi,

Am 15.03.2017 um 18:01 schrieb Mykhaylo Lyubun:
> Which step need execute to load changed code in code review which are executed?

You need to fix the original commit, not add new commits with fix-ups
but same non-telling commit message. The Change-Id line needs to remain
the same for Gerrit to associate different commits as updates of the
same patch.

See git commit --amend or git rebase -i.

Also, you should really create your own account - you can still push new
versions of the patchset using your own login. Note that if you make
changes they needs to carry your Signed-off-by too, not just your
colleague's.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel

[prev in list] [next in list] [prev in thread] [next in thread]