[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openocd-development
Subject:    [OpenOCD-devel] [PATCH]: 5b87e37 flash/nor/jtagspi: Fix uninitialized variable error.
From:       gerrit () openocd ! org (gerrit)
Date:       2015-08-11 8:45:58
Message-ID: 20150811084558.B179B198074E () mail ! openocd ! org
[Download RAW message or body]

This is an automated email from Gerrit.

Marc Schink (openocd-dev@marcschink.de) just uploaded a new patch set to Gerrit, \
which you can find at http://openocd.zylin.com/2909

-- gerrit

commit 5b87e37968d8ed5290f540cf22c90a250055b60a
Author: Marc Schink <openocd-dev@marcschink.de>
Date:   Tue Aug 11 10:44:38 2015 +0200

    flash/nor/jtagspi: Fix uninitialized variable error.
    
    Change-Id: Ic6ec4ef017dc9eedcdbe16afbb4861dc96b26a96
    Signed-off-by: Marc Schink <openocd-dev@marcschink.de>

diff --git a/src/flash/nor/jtagspi.c b/src/flash/nor/jtagspi.c
index 6ca5c3c..8896dcb 100644
--- a/src/flash/nor/jtagspi.c
+++ b/src/flash/nor/jtagspi.c
@@ -307,11 +307,11 @@ static int jtagspi_erase(struct flash_bank *bank, int first, \
int last)  retval = jtagspi_sector_erase(bank, sector);
 		if (retval != ERROR_OK) {
 			LOG_ERROR("Sector erase failed.");
-			break;
+			return retval;
 		}
 	}
 
-	return retval;
+	return ERROR_OK;
 }
 
 static int jtagspi_protect(struct flash_bank *bank, int set, int first, int last)

-- 

------------------------------------------------------------------------------
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel


[prev in list] [next in list] [prev in thread] [next in thread]