[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openocd-development
Subject:    [OpenOCD-devel] [PATCH]: 3e11560 Test the incoming debug_level, rather than the current.
From:       gerrit () openocd ! zylin ! com
Date:       2012-07-25 19:05:58
Message-ID: 20120725190558.5441C242E6 () openocd ! zylin ! com
[Download RAW message or body]

This is an automated email from Gerrit.

Alan Bowman (alan.michael.bowman@gmail.com) just uploaded a new patch set to Gerrit, \
which you can find at http://openocd.zylin.com/764

-- gerrit

commit 3e1156023ea5836991b0a3a25d0f5c4fd7105bc5
Author: Alan Bowman <alan.michael.bowman@gmail.com>
Date:   Wed Jul 25 19:58:11 2012 +0100

    Test the incoming debug_level, rather than the current.
    
    The existing code tests the current debug_level for validity, allowing
    the user to set it too high and never change it after that.  The new
    behaviour is to test the debug_level that the user has requested.
    
    Change-Id: I85726a2e606c8d137e9b1cfe76fee865084844b1
    Signed-off-by: Alan Bowman <alan.michael.bowman@gmail.com>

diff --git a/src/helper/log.c b/src/helper/log.c
index 74fdd65..ff84dbf 100644
--- a/src/helper/log.c
+++ b/src/helper/log.c
@@ -225,7 +225,7 @@ COMMAND_HANDLER(handle_debug_level_command)
 	if (CMD_ARGC == 1) {
 		int new_level;
 		COMMAND_PARSE_NUMBER(int, CMD_ARGV[0], new_level);
-		if ((debug_level > LOG_LVL_DEBUG) || (new_level < LOG_LVL_SILENT)) {
+		if ((new_level > LOG_LVL_DEBUG) || (new_level < LOG_LVL_SILENT)) {
 			LOG_ERROR("level must be between %d and %d", LOG_LVL_SILENT, LOG_LVL_DEBUG);
 			return ERROR_COMMAND_SYNTAX_ERROR;
 		}

-- 

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel


[prev in list] [next in list] [prev in thread] [next in thread]