[prev in list] [next in list] [prev in thread] [next in thread]
List: opennms-discuss
Subject: Re: [opennms-discuss] How can I make progress with NMS-9492 (DNS Import bug)?
From: Cyrille Bollu <cyrille.bollu () gmail ! com>
Date: 2017-08-24 10:45:55
Message-ID: CAAymSK6pjZ-c1X8coLXZNwrW1a1SUiHfWUeAZ0LUX5iH1UGxuA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Jonathan,
Yes, you'd better fork the code and create a pull request on github.
They explain how to do that in
https://github.com/OpenNMS/opennms/blob/develop/CONTRIBUTING.md
This is the newest way how to contribute.
Can you tell me where did you find that "attaching patches to a bug is a
valid way to submit changes"? So, I can adapt that documentation to mention
that gihub pull requests are prefered.
Best regards,
Cyrille
2017-08-23 13:10 GMT+02:00 Jonathan Heard <jonathan.heard@devinfotech.co.uk>
:
> Hi All,
>
> Quite a while back I raised a bug related to OpenNMS's DNS Import
> feature ( https://issues.opennms.org/browse/NMS-9492 ), I also emailed
> this list about it, and attached proposed patches to the bug report to
> address the issue. I'm really eager to discuss this problem with a view to
> getting my changes adopted because manually patching the affected JAR file
> is not ideal in the long-term.
>
> Is anyone else actually using this feature to provision nodes from DNS?
>
> The contribution guide says that attaching patches to a bug is a valid way
> to submit changes, but might I get a quicker response if I try the method
> of forking the code?
>
> The symptom I am trying to solve is that I get a flood of around 50 '
> uei.opennms.org/nodes/nodeUpdated' events for each of my ~300 nodes every
> single time my cron settings in provisiond-configuration.xml triggers a DNS
> Import.
>
> I'd really appreciate some advice on how best to progress this issue. I've
> included a further description below for anyone interested to read more.
>
> Thanks and regards
> Jonathan
>
> I'm currently running OpenNMS 20.0.1 on Ubuntu 14.04 using the official
> debian packages. I'm using the pristine configuration with a set of changes
> applied (this is aimed to replace a current installation which has been
> upgraded through many version and has lots of obsolete config files carried
> with it).
>
> I have attached an example of the the event flood for a single node during
> a DNS import. In our current production setup this would trigger thousands
> of email alerts (I'm fixing that through better config), but it also causes
> noise in the event list; potentially masking genuinely important events.
>
> By implementing a fix for NMS-9492 I am able to set 'rescanExisting =
> false' which stops the flood of messages but not triggering node updates.
> However I think there's still an outstanding issue. Beginning a DNS scan
> triggers ~100 'uei.opennms.org/internal/importer/importSuccessful' events
> (from 5 threads), and then if node rescanning is enabled it triggers the
> flood described above.
>
> In my opennms.properties I have:
> org.opennms.provisiond.scheduleRescanForExistingNodes=false
> org.opennms.provisiond.scheduleRescanForUpdatedNodes=false
>
> My provisiond-configuration.xml uses the following to import:
> <requisition-def import-name="test" import-url-resource="dns://ns0
> 1/test.zone/test/?services=ICMP&foreignidhashsource=name,label"
> rescan-existing="false">
> <cron-schedule>* 5/15 * * * ? *</cron-schedule>
> </requisition-def>
>
> i.e. Invoke the DNS import handler to do a zone transfer of 'test.zone'
> from 'ns01' every 15 minutes.
>
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Please read the OpenNMS Mailing List FAQ:
> http://www.opennms.org/index.php/Mailing_List_FAQ
>
> opennms-discuss mailing list
>
> To *unsubscribe* or change your subscription options, see the bottom of
> this page:
> https://lists.sourceforge.net/lists/listinfo/opennms-discuss
>
[Attachment #5 (text/html)]
<div dir="ltr"><div><div><div><div><div>Hi Jonathan,<br><br></div><div></div>Yes, \
you'd better fork the code and create a pull request on github.<br><br></div>They \
explain how to do that in <a \
href="https://github.com/OpenNMS/opennms/blob/develop/CONTRIBUTING.md">https://github.com/OpenNMS/opennms/blob/develop/CONTRIBUTING.md</a><br><br></div>This \
is the newest way how to contribute.<br><br></div>Can you tell me where did you find \
that "attaching patches to a bug is a valid way to submit changes"? So, I \
can adapt that documentation to mention that gihub pull requests are \
prefered.<br><br>Best \
regards,<br><br></div>Cyrille<br><div><div><div><br></div></div></div></div><div \
class="gmail_extra"><br><div class="gmail_quote">2017-08-23 13:10 GMT+02:00 Jonathan \
Heard <span dir="ltr"><<a href="mailto:jonathan.heard@devinfotech.co.uk" \
target="_blank">jonathan.heard@devinfotech.co.uk</a>></span>:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi All,<br> <br>
Quite a while back I raised a bug related to OpenNMS's DNS Import feature ( \
<a href="https://issues.opennms.org/browse/NMS-9492" rel="noreferrer" \
target="_blank">https://issues.opennms.org/bro<wbr>wse/NMS-9492</a> ), I also emailed \
this list about it, and attached proposed patches to the bug report to address the \
issue. I'm really eager to discuss this problem with a view to getting my \
changes adopted because manually patching the affected JAR file is not ideal in the \
long-term.<br> <br>
Is anyone else actually using this feature to provision nodes from DNS?<br>
<br>
The contribution guide says that attaching patches to a bug is a valid way to submit \
changes, but might I get a quicker response if I try the method of forking the \
code?<br> <br>
The symptom I am trying to solve is that I get a flood of around 50 '<a \
href="http://uei.opennms.org/nodes/nodeUpdated" rel="noreferrer" \
target="_blank">uei.opennms.org/nodes/nodeUpd<wbr>ated</a>' events for each of my \
~300 nodes every single time my cron settings in provisiond-configuration.xml \
triggers a DNS Import.<br> <br>
I'd really appreciate some advice on how best to progress this issue. I've \
included a further description below for anyone interested to read more.<br> <br>
Thanks and regards<br>
Jonathan<br>
<br>
I'm currently running OpenNMS 20.0.1 on Ubuntu 14.04 using the official debian \
packages. I'm using the pristine configuration with a set of changes applied \
(this is aimed to replace a current installation which has been upgraded through many \
version and has lots of obsolete config files carried with it).<br> <br>
I have attached an example of the the event flood for a single node during a DNS \
import. In our current production setup this would trigger thousands of email alerts \
(I'm fixing that through better config), but it also causes noise in the event \
list; potentially masking genuinely important events.<br> <br>
By implementing a fix for NMS-9492 I am able to set 'rescanExisting = false' \
which stops the flood of messages but not triggering node updates. However I think \
there's still an outstanding issue. Beginning a DNS scan triggers ~100 '<a \
href="http://uei.opennms.org/internal/importer/importSuccessful" rel="noreferrer" \
target="_blank">uei.opennms.org/internal/impo<wbr>rter/importSuccessful</a>' \
events (from 5 threads), and then if node rescanning is enabled it triggers the flood \
described above.<br> <br>
In my opennms.properties I have:<br>
org.opennms.provisiond.schedul<wbr>eRescanForExistingNodes=false<br>
org.opennms.provisiond.schedul<wbr>eRescanForUpdatedNodes=false<br>
<br>
My provisiond-configuration.xml uses the following to import:<br>
<requisition-def import-name="test" \
import-url-resource="dns://ns0<wbr>1/test.zone/test/?services=ICM<wbr>P&amp;foreignidhashsource=name<wbr>,label" \
rescan-existing="false"><br> <cron-schedule>* 5/15 * * * ? \
*</cron-schedule><br> </requisition-def><br>
<br>
i.e. Invoke the DNS import handler to do a zone transfer of 'test.zone' from \
'ns01' every 15 minutes.<br> <br>
<br>------------------------------<wbr>------------------------------<wbr>------------------<br>
Check out the vibrant tech community on one of the world's most<br>
engaging tech sites, Slashdot.org! <a href="http://sdm.link/slashdot" \
rel="noreferrer" target="_blank">http://sdm.link/slashdot</a><br>______________________________<wbr>_________________<br>
Please read the OpenNMS Mailing List FAQ:<br>
<a href="http://www.opennms.org/index.php/Mailing_List_FAQ" rel="noreferrer" \
target="_blank">http://www.opennms.org/index.<wbr>php/Mailing_List_FAQ</a><br> <br>
opennms-discuss mailing list<br>
<br>
To *unsubscribe* or change your subscription options, see the bottom of this \
page:<br> <a href="https://lists.sourceforge.net/lists/listinfo/opennms-discuss" \
rel="noreferrer" target="_blank">https://lists.sourceforge.net/<wbr>lists/listinfo/opennms-discuss</a><br></blockquote></div><br></div>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/index.php/Mailing_List_FAQ
opennms-discuss mailing list
To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-discuss
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic