[prev in list] [next in list] [prev in thread] [next in thread] 

List:       opennms-buglist
Subject:    [Buglist] [JIRA] (NMS-5090) Notification names cannot contain an apostrouphe it breaks the Java scri
From:       jira () opennms ! org (Alejandro Galue (JIRA))
Date:       2011-12-21 17:17:31
Message-ID: 819929301.711.1324487851402.JavaMail.jira () mail1 ! opennms ! com
[Download RAW message or body]


     [ http://issues.opennms.org/browse/NMS-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel \
]

Alejandro Galue resolved NMS-5090.
----------------------------------

    Fix Version/s: 1.9.94
       Resolution: Fixed

The problem is that the JavaScript expects that the string is properly escaped, \
otherwise the generated code will looks like this:

{code:xml}
<input type="radio" value="On" onclick="javascript:setStatus('Alejandro's \
Event','on')"/>On {code}

Instead of:

{code:xml}
<input type="radio" value="On" onclick="javascript:setStatus('Alejandro\'s \
Event','on')"/>On {code}

I've used org.apache.commons.lang.StringEscapeUtils.escapeJavaScript to fix the \
problem.

Fixed on revision ac589099ce611b4810867101f31298cad9cdc031 for 1.10.
Fixed on revision a4e6fa69ad0312da6ad77f105d47fda3cf1eb312 for 1.8.

                
> Notification names cannot contain an apostrouphe it breaks the Java script
> --------------------------------------------------------------------------
> 
> Key: NMS-5090
> URL: http://issues.opennms.org/browse/NMS-5090
> Project: OpenNMS
> Issue Type: Bug
> Components: Web UI - Admin
> Affects Versions: 1.8.16
> Reporter: David Hustace
> Assignee: Alejandro Galue
> Priority: Minor
> Labels: support
> Fix For: 1.8.17, 1.9.94
> 
> 
> The radio and edit buttons don't work when you have an apostrophe in the name of \
> the notification you've created... (Dr., it hurts when I do this..)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: \
http://issues.opennms.org/secure/ContactAdministrators!default.jspa For more \
information on JIRA, see: http://www.atlassian.com/software/jira

        


[prev in list] [next in list] [prev in thread] [next in thread]