[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openmrs-svn
Subject:    [29405] openmrs-modules/idgen/trunk: IDGEN-17 - Identifier Pools should be able to refill themselves
From:       svn-noreply () openmrs ! org
Date:       2012-09-27 17:29:19
Message-ID: 20120927172919.8E19A401C9 () openmrs ! osuosl ! org
[Download RAW message or body]

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29405] openmrs-modules/idgen/trunk: IDGEN-17 - Identifier Pools should be \
able to refill themselves on a scheduled task</title> </head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt;  } #msg dl a { font-weight: \
bold} #msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: \
6px; } #logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em \
0; } #logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg \
h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; } \
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; \
} #logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: \
-1.5em; padding-left: 1.5em; } #logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em \
1em 0 1em; background: white;} #logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid \
#fa0; border-bottom: 1px solid #fa0; background: #fff; } #logmsg table th { \
text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted \
#fa0; } #logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: \
0.2em 0.5em; } #logmsg table thead th { text-align: center; border-bottom: 1px solid \
#fa0; } #logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
 #patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
                .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd>29405</dd>
<dt>Author</dt> <dd>darius</dd>
<dt>Date</dt> <dd>2012-09-27 17:29:19 +0000 (Thu, 27 Sep 2012)</dd>
</dl>

<h3>Log Message</h3>
<pre>IDGEN-17 - Identifier Pools should be able to refill themselves on a scheduled \
task</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#openmrsmodulesidgentrunkapisrcmainjavaorgopenmrsmoduleidgenIdentifierPoo \
ljava">openmrs-modules/idgen/trunk/api/src/main/java/org/openmrs/module/idgen/IdentifierPool.java</a></li>
 <li><a href="#openmrsmodulesidgentrunkapisrcmainjavaorgopenmrsmoduleidgenprocessorIde \
ntifierPoolProcessorjava">openmrs-modules/idgen/trunk/api/src/main/java/org/openmrs/module/idgen/processor/IdentifierPoolProcessor.java</a></li>
 <li><a href="#openmrsmodulesidgentrunkapisrcmainresourcesIdentifierSourcehbmxml">openmrs-modules/idgen/trunk/api/src/main/resources/IdentifierSource.hbm.xml</a></li>
 <li><a href="#openmrsmodulesidgentrunkapisrcmainresourcesmessagesproperties">openmrs-modules/idgen/trunk/api/src/main/resources/messages.properties</a></li>
 <li><a href="#openmrsmodulesidgentrunkapisrcmainresourcesmoduleApplicationContextxml" \
>openmrs-modules/idgen/trunk/api/src/main/resources/moduleApplicationContext.xml</a></li>
> 
<li><a href="#openmrsmodulesidgentrunkapisrctestjavaorgopenmrsmoduleidgenintegrationRe \
moteWithLocalPoolIntegrationTestjava">openmrs-modules/idgen/trunk/api/src/test/java/or \
g/openmrs/module/idgen/integration/RemoteWithLocalPoolIntegrationTest.java</a></li> \
<li><a href="#openmrsmodulesidgentrunkapisrctestresourcesTestingApplicationContextxml" \
>openmrs-modules/idgen/trunk/api/src/test/resources/TestingApplicationContext.xml</a></li>
> 
<li><a href="#openmrsmodulesidgentrunkapisrctestresourcesorgopenmrsmoduleidgenincludeT \
estDataxml">openmrs-modules/idgen/trunk/api/src/test/resources/org/openmrs/module/idgen/include/TestData.xml</a></li>
 <li><a href="#openmrsmodulesidgentrunkomodsrcmainresourcessqldiffxml">openmrs-modules/idgen/trunk/omod/src/main/resources/sqldiff.xml</a></li>
 <li><a href="#openmrsmodulesidgentrunkomodsrcmainwebappeditIdentifierSourcejsp">openmrs-modules/idgen/trunk/omod/src/main/webapp/editIdentifierSource.jsp</a></li>
 <li><a href="#openmrsmodulesidgentrunkpomxml">openmrs-modules/idgen/trunk/pom.xml</a></li>
 </ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="openmrsmodulesidgentrunkapisrcmainjavaorgopenmrsmoduleidgenIdentifierPooljava"></a>
 <div class="modfile"><h4>Modified: \
openmrs-modules/idgen/trunk/api/src/main/java/org/openmrs/module/idgen/IdentifierPool.java \
(29404 => 29405)</h4> <pre class="diff"><span>
<span class="info">--- \
openmrs-modules/idgen/trunk/api/src/main/java/org/openmrs/module/idgen/IdentifierPool.java	2012-09-27 \
                14:54:42 UTC (rev 29404)
+++ openmrs-modules/idgen/trunk/api/src/main/java/org/openmrs/module/idgen/IdentifierPool.java	2012-09-27 \
17:29:19 UTC (rev 29405) </span><span class="lines">@@ -33,7 +33,8 @@
</span><span class="cx">     private int minPoolSize = 500; // request more when we \
go below this number </span><span class="cx">     private boolean sequential = false;
</span><span class="cx">     private Set&lt;PooledIdentifier&gt; identifiers;
</span><del>-	
</del><ins>+    private boolean refillWithScheduledTask = true; // if true, refill \
with a scheduled task, otherwise refill on demands for ids +
</ins><span class="cx">     //***** INSTANCE METHODS *****
</span><span class="cx">    
</span><span class="cx">     /**
</span><span class="lines">@@ -157,4 +158,19 @@
</span><span class="cx"> 	public void setIdentifiers(Set&lt;PooledIdentifier&gt; \
identifiers) { </span><span class="cx"> 		this.identifiers = identifiers;
</span><span class="cx"> 	}
</span><ins>+
+    /**
+     * @return the refillWithScheduledTask
+     */
+    public boolean isRefillWithScheduledTask() {
+        return refillWithScheduledTask;
+    }
+
+    /**
+     * @param refillWithScheduledTask the refillWithScheduledTask to set
+     */
+    public void setRefillWithScheduledTask(boolean refillWithScheduledTask) {
+        this.refillWithScheduledTask = refillWithScheduledTask;
+    }
+
</ins><span class="cx"> }
</span></span></pre></div>
<a id="openmrsmodulesidgentrunkapisrcmainjavaorgopenmrsmoduleidgenprocessorIdentifierPoolProcessorjava"></a>
 <div class="modfile"><h4>Modified: \
openmrs-modules/idgen/trunk/api/src/main/java/org/openmrs/module/idgen/processor/IdentifierPoolProcessor.java \
(29404 => 29405)</h4> <pre class="diff"><span>
<span class="info">--- \
openmrs-modules/idgen/trunk/api/src/main/java/org/openmrs/module/idgen/processor/IdentifierPoolProcessor.java	2012-09-27 \
                14:54:42 UTC (rev 29404)
+++ openmrs-modules/idgen/trunk/api/src/main/java/org/openmrs/module/idgen/processor/IdentifierPoolProcessor.java	2012-09-27 \
17:29:19 UTC (rev 29405) </span><span class="lines">@@ -34,7 +34,9 @@
</span><span class="cx"> 	public synchronized List&lt;String&gt; \
getIdentifiers(IdentifierSource source, int batchSize) { </span><span class="cx"> \
IdentifierPool pool = (IdentifierPool) source; </span><span class="cx"> \
IdentifierSourceService iss = Context.getService(IdentifierSourceService.class); \
</span><del>-		iss.checkAndRefillIdentifierPool(pool); </del><ins>+        if \
(!pool.isRefillWithScheduledTask()) { +		    iss.checkAndRefillIdentifierPool(pool);
+        }
</ins><span class="cx"> 		List&lt;PooledIdentifier&gt; available = \
iss.getAvailableIdentifiers(pool, batchSize); </span><span class="cx"> \
List&lt;String&gt; ret = new ArrayList&lt;String&gt;(); </span><span class="cx"> \
Date now = new Date(); </span></span></pre></div>
<a id="openmrsmodulesidgentrunkapisrcmainresourcesIdentifierSourcehbmxml"></a>
<div class="modfile"><h4>Modified: \
openmrs-modules/idgen/trunk/api/src/main/resources/IdentifierSource.hbm.xml (29404 => \
29405)</h4> <pre class="diff"><span>
<span class="info">--- \
openmrs-modules/idgen/trunk/api/src/main/resources/IdentifierSource.hbm.xml	2012-09-27 \
                14:54:42 UTC (rev 29404)
+++ openmrs-modules/idgen/trunk/api/src/main/resources/IdentifierSource.hbm.xml	2012-09-27 \
17:29:19 UTC (rev 29405) </span><span class="lines">@@ -44,7 +44,8 @@
</span><span class="cx"> 			&lt;many-to-one name=&quot;source&quot; \
class=&quot;IdentifierSource&quot; lazy=&quot;false&quot; /&gt; </span><span \
class="cx"> 			&lt;property name=&quot;batchSize&quot; type=&quot;int&quot; \
column=&quot;batch_size&quot; /&gt; </span><span class="cx"> 			&lt;property \
name=&quot;minPoolSize&quot; type=&quot;int&quot; column=&quot;min_pool_size&quot; \
/&gt; </span><del>-			&lt;property name=&quot;sequential&quot; \
type=&quot;java.lang.Boolean&quot; length=&quot;1&quot; \
not-null=&quot;true&quot;/&gt; </del><ins>+            &lt;property \
name=&quot;refillWithScheduledTask&quot; type=&quot;java.lang.Boolean&quot; \
column=&quot;refill_with_scheduled_task&quot; length=&quot;1&quot; \
not-null=&quot;true&quot;/&gt; +            &lt;property name=&quot;sequential&quot; \
type=&quot;java.lang.Boolean&quot; length=&quot;1&quot; \
not-null=&quot;true&quot;/&gt; </ins><span class="cx"> 			&lt;set \
name=&quot;identifiers&quot; lazy=&quot;true&quot; \
cascade=&quot;all-delete-orphan&quot; inverse=&quot;true&quot; \
access=&quot;field&quot;&gt; </span><span class="cx"> 				&lt;key \
column=&quot;pool_id&quot; not-null=&quot;true&quot; /&gt; </span><span class="cx"> \
&lt;one-to-many class=&quot;PooledIdentifier&quot; /&gt; </span></span></pre></div>
<a id="openmrsmodulesidgentrunkapisrcmainresourcesmessagesproperties"></a>
<div class="modfile"><h4>Modified: \
openmrs-modules/idgen/trunk/api/src/main/resources/messages.properties (29404 => \
29405)</h4> <pre class="diff"><span>
<span class="info">--- \
openmrs-modules/idgen/trunk/api/src/main/resources/messages.properties	2012-09-27 \
                14:54:42 UTC (rev 29404)
+++ openmrs-modules/idgen/trunk/api/src/main/resources/messages.properties	2012-09-27 \
17:29:19 UTC (rev 29405) </span><span class="lines">@@ -40,6 +40,9 @@
</span><span class="cx"> idgen.order = Order
</span><span class="cx"> idgen.random = Random
</span><span class="cx"> idgen.sequential = Sequential
</span><ins>+idgen.scheduledFill = When to fill
+idgen.scheduledFill.scheduled = Background task
+idgen.scheduledFill.onDemand = When you request an identifier
</ins><span class="cx"> idgen.autoGenerate = Generate
</span><span class="cx"> idgen.autoGenerateLabel = Will be Auto-Generated when saved
</span><span class="cx"> idgen.autoGenerationConfiguration = Auto-Generation \
Configuration </span></span></pre></div>
<a id="openmrsmodulesidgentrunkapisrcmainresourcesmoduleApplicationContextxml"></a>
<div class="modfile"><h4>Modified: \
openmrs-modules/idgen/trunk/api/src/main/resources/moduleApplicationContext.xml \
(29404 => 29405)</h4> <pre class="diff"><span>
<span class="info">--- \
openmrs-modules/idgen/trunk/api/src/main/resources/moduleApplicationContext.xml	2012-09-27 \
                14:54:42 UTC (rev 29404)
+++ openmrs-modules/idgen/trunk/api/src/main/resources/moduleApplicationContext.xml	2012-09-27 \
17:29:19 UTC (rev 29405) </span><span class="lines">@@ -1,9 +1,16 @@
</span><span class="cx"> &lt;?xml version=&quot;1.0&quot; \
encoding=&quot;UTF-8&quot;?&gt; </span><del>-&lt;!DOCTYPE beans PUBLIC \
&quot;-//SPRING//DTD BEAN//EN&quot; \
&quot;http://www.springframework.org/dtd/spring-beans.dtd&quot;&gt; </del><span \
class="cx">  </span><del>-&lt;!-- Beans to add to the current Application context \
definition --&gt; </del><ins>+&lt;beans \
xmlns=&quot;http://www.springframework.org/schema/beans&quot; +       \
xmlns:xsi=&quot;http://www.w3.org/2001/XMLSchema-instance&quot; +       \
xmlns:context=&quot;http://www.springframework.org/schema/context&quot; +       \
xmlns:util=&quot;http://www.springframework.org/schema/util&quot; +       \
xsi:schemaLocation=&quot;http://www.springframework.org/schema/beans +           \
http://www.springframework.org/schema/beans/spring-beans-2.5.xsd +           \
http://www.springframework.org/schema/context +           \
http://www.springframework.org/schema/context/spring-context-2.5.xsd +           \
http://www.springframework.org/schema/util +           \
http://www.springframework.org/schema/util/spring-util-2.0.xsd&quot;&gt; </ins><span \
class="cx">  </span><del>-&lt;beans&gt;
</del><span class="cx"> 	&lt;bean id=&quot;baseIdentifierSourceService&quot; \
class=&quot;org.openmrs.module.idgen.service.BaseIdentifierSourceService&quot;&gt; \
</span><span class="cx"> 		&lt;property name=&quot;dao&quot;&gt; </span><span \
class="cx"> 			&lt;bean \
class=&quot;org.openmrs.module.idgen.service.db.HibernateIdentifierSourceDAO&quot;&gt;
 </span><span class="lines">@@ -68,4 +75,19 @@
</span><span class="cx"> 			&lt;/map&gt;
</span><span class="cx"> 		&lt;/property&gt;
</span><span class="cx"> 	&lt;/bean&gt;
</span><ins>+
+    &lt;bean id=&quot;idgenTimerFactory&quot; \
class=&quot;org.springframework.scheduling.timer.TimerFactoryBean&quot;&gt; +        \
&lt;property name=&quot;scheduledTimerTasks&quot;&gt; +            &lt;list&gt;
+                &lt;bean id=&quot;refillIdentifierPools&quot; \
class=&quot;org.springframework.scheduling.timer.ScheduledTimerTask&quot;&gt; +       \
&lt;property name=&quot;delay&quot; value=&quot;10000&quot; /&gt; &lt;!-- delay 10 \
seconds --&gt; +                    &lt;property name=&quot;period&quot; \
value=&quot;300000&quot; /&gt; &lt;!-- run every 5 minutes --&gt; +                   \
&lt;property name=&quot;timerTask&quot;&gt; +                        &lt;bean \
class=&quot;org.openmrs.module.idgen.task.RefillIdentifierPoolsTask&quot;/&gt; +      \
&lt;/property&gt; +                &lt;/bean&gt;
+            &lt;/list&gt;
+        &lt;/property&gt;
+    &lt;/bean&gt;
+
</ins><span class="cx"> &lt;/beans&gt;
</span></span></pre></div>
<a id="openmrsmodulesidgentrunkapisrctestjavaorgopenmrsmoduleidgenintegrationRemoteWithLocalPoolIntegrationTestjava"></a>
 <div class="modfile"><h4>Modified: \
openmrs-modules/idgen/trunk/api/src/test/java/org/openmrs/module/idgen/integration/RemoteWithLocalPoolIntegrationTest.java \
(29404 => 29405)</h4> <pre class="diff"><span>
<span class="info">--- \
openmrs-modules/idgen/trunk/api/src/test/java/org/openmrs/module/idgen/integration/RemoteWithLocalPoolIntegrationTest.java	2012-09-27 \
                14:54:42 UTC (rev 29404)
+++ openmrs-modules/idgen/trunk/api/src/test/java/org/openmrs/module/idgen/integration/RemoteWithLocalPoolIntegrationTest.java	2012-09-27 \
17:29:19 UTC (rev 29405) </span><span class="lines">@@ -65,6 +65,7 @@
</span><span class="cx"> 		pool.setMinPoolSize(4);
</span><span class="cx"> 		pool.setBatchSize(3);
</span><span class="cx"> 		pool.setSequential(true);
</span><ins>+        pool.setRefillWithScheduledTask(false);
</ins><span class="cx"> 		service.saveIdentifierSource(pool);
</span><span class="cx"> 		
</span><span class="cx"> 		// set up auto generation from the local pool (not the \
remote source) </span></span></pre></div>
<a id="openmrsmodulesidgentrunkapisrctestresourcesTestingApplicationContextxml"></a>
<div class="modfile"><h4>Modified: \
openmrs-modules/idgen/trunk/api/src/test/resources/TestingApplicationContext.xml \
(29404 => 29405)</h4> <pre class="diff"><span>
<span class="info">--- \
openmrs-modules/idgen/trunk/api/src/test/resources/TestingApplicationContext.xml	2012-09-27 \
                14:54:42 UTC (rev 29404)
+++ openmrs-modules/idgen/trunk/api/src/test/resources/TestingApplicationContext.xml	2012-09-27 \
17:29:19 UTC (rev 29405) </span><span class="lines">@@ -25,5 +25,19 @@
</span><span class="cx"> 		&lt;/property&gt;
</span><span class="cx"> 		&lt;!--  default properties must be set in the \
hibernate.default.properties --&gt; </span><span class="cx"> 	&lt;/bean&gt;
</span><ins>+
+    &lt;bean id=&quot;idgenTestTimerFactory&quot; \
class=&quot;org.springframework.scheduling.timer.TimerFactoryBean&quot;&gt; +        \
&lt;property name=&quot;scheduledTimerTasks&quot;&gt; +            &lt;list&gt;
+                &lt;bean id=&quot;refillIdentifierPools&quot; \
class=&quot;org.springframework.scheduling.timer.ScheduledTimerTask&quot;&gt; +       \
&lt;property name=&quot;delay&quot; value=&quot;5000&quot; /&gt; +                    \
&lt;property name=&quot;period&quot; value=&quot;5000&quot; /&gt; +                   \
&lt;property name=&quot;timerTask&quot;&gt; +                        &lt;bean \
class=&quot;org.openmrs.module.idgen.task.TestTask&quot;/&gt; +                    \
&lt;/property&gt; +                &lt;/bean&gt;
+            &lt;/list&gt;
+        &lt;/property&gt;
+    &lt;/bean&gt;
</ins><span class="cx"> 	
</span><span class="cx"> &lt;/beans&gt;
</span></span></pre></div>
<a id="openmrsmodulesidgentrunkapisrctestresourcesorgopenmrsmoduleidgenincludeTestDataxml"></a>
 <div class="modfile"><h4>Modified: \
openmrs-modules/idgen/trunk/api/src/test/resources/org/openmrs/module/idgen/include/TestData.xml \
(29404 => 29405)</h4> <pre class="diff"><span>
<span class="info">--- \
openmrs-modules/idgen/trunk/api/src/test/resources/org/openmrs/module/idgen/include/TestData.xml	2012-09-27 \
                14:54:42 UTC (rev 29404)
+++ openmrs-modules/idgen/trunk/api/src/test/resources/org/openmrs/module/idgen/include/TestData.xml	2012-09-27 \
17:29:19 UTC (rev 29405) </span><span class="lines">@@ -9,7 +9,7 @@
</span><span class="cx"> 	
</span><span class="cx"> 	&lt;IDGEN_REMOTE_SOURCE ID=&quot;2&quot; \
URL=&quot;http://localhost:8080/openmrs/module/idgen/getIdentifier&quot;/&gt; \
</span><span class="cx"> 	 </span><del>-	&lt;IDGEN_ID_POOL ID=&quot;3&quot; \
SOURCE=&quot;1&quot; BATCH_SIZE=&quot;1000&quot; MIN_POOL_SIZE=&quot;100&quot; \
sequential=&quot;1&quot;/&gt; </del><ins>+	&lt;IDGEN_ID_POOL ID=&quot;3&quot; \
SOURCE=&quot;1&quot; BATCH_SIZE=&quot;1000&quot; MIN_POOL_SIZE=&quot;100&quot; \
sequential=&quot;1&quot; refill_with_scheduled_task=&quot;0&quot;/&gt; </ins><span \
class="cx"> 	 </span><span class="cx"> 	&lt;IDGEN_POOLED_IDENTIFIER ID=&quot;1&quot; \
POOL_ID=&quot;3&quot;  IDENTIFIER=&quot;00001&quot; \
UUID=&quot;1d47284f-9e9b-4a81-a88b-8bb42bc0a901&quot;/&gt; </span><span class="cx"> \
&lt;IDGEN_POOLED_IDENTIFIER ID=&quot;2&quot; POOL_ID=&quot;3&quot;  \
IDENTIFIER=&quot;00002&quot; \
UUID=&quot;2d47284f-9e9b-4a81-a88b-8bb42bc0a901&quot;/&gt; </span></span></pre></div>
<a id="openmrsmodulesidgentrunkomodsrcmainresourcessqldiffxml"></a>
<div class="modfile"><h4>Modified: \
openmrs-modules/idgen/trunk/omod/src/main/resources/sqldiff.xml (29404 => 29405)</h4> \
<pre class="diff"><span> <span class="info">--- \
openmrs-modules/idgen/trunk/omod/src/main/resources/sqldiff.xml	2012-09-27 14:54:42 \
                UTC (rev 29404)
+++ openmrs-modules/idgen/trunk/omod/src/main/resources/sqldiff.xml	2012-09-27 \
17:29:19 UTC (rev 29405) </span><span class="lines">@@ -122,9 +122,9 @@
</span><span class="cx"> 	&lt;diff&gt;
</span><span class="cx"> 		&lt;version&gt;2.0&lt;/version&gt;
</span><span class="cx"> 		&lt;author&gt;Partners In Health&lt;/author&gt;
</span><del>-		&lt;date&gt;28 June 2010&lt;/date&gt;
</del><ins>+		&lt;date&gt;27 Sept 2012&lt;/date&gt;
</ins><span class="cx"> 		&lt;description&gt;
</span><del>-			Add table for reserved identifiers
</del><ins>+			Add column for pools to indicate whether they're scheduled or not
</ins><span class="cx"> 		&lt;/description&gt;
</span><span class="cx"> 		&lt;sql&gt;
</span><span class="cx"> 			CREATE TABLE `idgen_reserved_identifier` (
</span><span class="lines">@@ -138,4 +138,16 @@
</span><span class="cx"> 			) ENGINE=InnoDB DEFAULT CHARSET=utf8;
</span><span class="cx"> 		&lt;/sql&gt;	
</span><span class="cx"> 	&lt;/diff&gt;
</span><ins>+
+    &lt;diff&gt;
+        &lt;version&gt;2.4&lt;/version&gt;
+        &lt;author&gt;Partners In Health&lt;/author&gt;
+        &lt;date&gt;28 June 2010&lt;/date&gt;
+        &lt;description&gt;
+            Add table for reserved identifiers
+        &lt;/description&gt;
+        &lt;sql&gt;
+            ALTER TABLE `idgen_id_pool` ADD COLUMN `refill_with_scheduled_task` \
tinyint(1) NOT NULL default 1; +        &lt;/sql&gt;
+    &lt;/diff&gt;
</ins><span class="cx"> &lt;/sqldiff&gt;
</span><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="openmrsmodulesidgentrunkomodsrcmainwebappeditIdentifierSourcejsp"></a>
<div class="modfile"><h4>Modified: \
openmrs-modules/idgen/trunk/omod/src/main/webapp/editIdentifierSource.jsp (29404 => \
29405)</h4> <pre class="diff"><span>
<span class="info">--- \
openmrs-modules/idgen/trunk/omod/src/main/webapp/editIdentifierSource.jsp	2012-09-27 \
                14:54:42 UTC (rev 29404)
+++ openmrs-modules/idgen/trunk/omod/src/main/webapp/editIdentifierSource.jsp	2012-09-27 \
17:29:19 UTC (rev 29405) </span><span class="lines">@@ -137,7 +137,14 @@
</span><span class="cx"> 					&lt;frm:radiobutton path=&quot;sequential&quot; \
value=&quot;${true}&quot; /&gt; &lt;spring:message code=&quot;idgen.sequential&quot; \
/&gt; </span><span class="cx"> 					&lt;frm:errors path=&quot;sequential&quot; \
cssClass=&quot;error&quot; /&gt;&lt;/td&gt; </span><span class="cx"> 			&lt;/tr&gt;
</span><del>-			&lt;tr&gt;
</del><ins>+            &lt;tr&gt;
+                &lt;th align=&quot;right&quot;&gt;&lt;spring:message \
code=&quot;idgen.scheduledFill&quot; /&gt;:&lt;/th&gt; +                &lt;td&gt;
+                    &lt;frm:radiobutton path=&quot;refillWithScheduledTask&quot; \
value=&quot;${true}&quot; /&gt; &lt;spring:message \
code=&quot;idgen.scheduledFill.scheduled&quot; /&gt; +                    \
&lt;frm:radiobutton path=&quot;refillWithScheduledTask&quot; \
value=&quot;${false}&quot; /&gt; &lt;spring:message \
code=&quot;idgen.scheduledFill.onDemand&quot; /&gt; +                    \
&lt;frm:errors path=&quot;refillWithScheduledTask&quot; cssClass=&quot;error&quot; \
/&gt;&lt;/td&gt; +            &lt;/tr&gt;
+            &lt;tr&gt;
</ins><span class="cx"> 				&lt;th align=&quot;right&quot;&gt;&lt;spring:message \
code=&quot;idgen.batchSize&quot; /&gt;:&lt;/th&gt; </span><span class="cx"> \
&lt;td&gt;&lt;frm:input path=&quot;batchSize&quot; size=&quot;50&quot; \
/&gt;&lt;frm:errors path=&quot;batchSize&quot; cssClass=&quot;error&quot; \
/&gt;&lt;/td&gt; </span><span class="cx"> 			&lt;/tr&gt;
</span></span></pre></div>
<a id="openmrsmodulesidgentrunkpomxml"></a>
<div class="modfile"><h4>Modified: openmrs-modules/idgen/trunk/pom.xml (29404 => \
29405)</h4> <pre class="diff"><span>
<span class="info">--- openmrs-modules/idgen/trunk/pom.xml	2012-09-27 14:54:42 UTC \
                (rev 29404)
+++ openmrs-modules/idgen/trunk/pom.xml	2012-09-27 17:29:19 UTC (rev 29405)
</span><span class="lines">@@ -59,6 +59,13 @@
</span><span class="cx"> 			&lt;type&gt;pom&lt;/type&gt;
</span><span class="cx"> 			&lt;scope&gt;test&lt;/scope&gt;
</span><span class="cx"> 		&lt;/dependency&gt;
</span><ins>+
+        &lt;dependency&gt;
+            &lt;groupId&gt;org.mockito&lt;/groupId&gt;
+            &lt;artifactId&gt;mockito-all&lt;/artifactId&gt;
+            &lt;version&gt;1.9.0&lt;/version&gt;
+            &lt;scope&gt;test&lt;/scope&gt;
+        &lt;/dependency&gt;
</ins><span class="cx"> 	&lt;/dependencies&gt;
</span><span class="cx"> 
</span><span class="cx"> 	&lt;properties&gt;
</span></span></pre>
</div>
</div>

</body>
</html>

<p></p>

-- OpenMRS Subversion Commits: <a \
href="http://go.openmrs.org/svn">http://go.openmrs.org/svn</a><br /> Posting is not \
                allowed - please join dev@openmrs.org for discussion.<br />
Unsubscribe: svn+unsubscribe@openmrs.org


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic