[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openmrs-dev
Subject:    Re: Regarding usage of <c:out value="${identifier}" /> instead of ${identifier}
From:       Lluis Martinez <lluismf () gmail ! com>
Date:       2014-03-31 23:51:03
Message-ID: CAAmjNgbrkgsdbDCL7KMFnVagwmaTxADgfQBLA2ZoeUOOOoMj6g () mail ! gmail ! com
[Download RAW message or body]

Are you sure it's not a bug in your code? The void checkbox is also not
visible.


On Tue, Apr 1, 2014 at 12:26 AM, Akash Agrawall <akash.wanted@gmail.com>wrote:

> @Lluis Thanks for this idea but in openmrs version 1.11 we don't have a
> space for voidReason.(Screenshot attached)
> 
> 
> On Sun, Mar 30, 2014 at 9:08 PM, Darius Jazayeri <djazayeri@gmail.com>wrote:
> 
> > That makes sense, and also, can we check to make sure
> > PatientIdentifier.toString() can't throw an NPE?
> > 
> > -Darius (by phone)
> > On Mar 30, 2014 10:10 AM, "Lluis Martinez" <lluismf@gmail.com> wrote:
> > 
> > > Currently the void reason row ID is made up by concatenating the
> > > identifier (which can be null). Why not just using the index of the
> > > identifiers array, as the void reason input does? (see image)
> > > 
> > > Instead of voidReasonIdentifierRow-1007HK the DOM id would be
> > > voidReasonIdentifierRow[0]
> > > 
> > > PS: the behaviour of this form is fragile, for instance if multiple
> > > identifiers are added and some error occurs all but one disappear
> > > 
> > > 
> > > 
> > > On Sun, Mar 30, 2014 at 3:54 AM, Darius Jazayeri <djazayeri@gmail.com>wrote:
> > > 
> > > > We shouldn't have to do this, though. The c-rt tag libraries do not
> > > > typically fail in this case.
> > > > 
> > > > Can we find out what the real problem is rather than wrapping excessive
> > > > error checking around what is just a print statement?
> > > > 
> > > > -Darius (by phone)
> > > > On Mar 29, 2014 8:30 PM, "Akash Agrawall" <akash.wanted@gmail.com>
> > > > wrote:
> > > > 
> > > > > Sorry for that. Yaa this was the case I guess. Changed it to:
> > > > > <c:choose>
> > > > > <c:when test="${empty identifier}">
> > > > > <tr id="voidReasonIdentifierRow-<c:out
> > > > > value="${identifier}" />" <spring:bind path="voided"><c:if
> > > > > test="${status.value == false}">style="display: none"</c:if></spring:bind> \
> > > > > > </c:when>
> > > > > <c:otherwise>
> > > > > <tr id="voidReasonIdentifierRow-${identifier}"
> > > > > <spring:bind path="voided"><c:if test="${status.value ==
> > > > > false}">style="display: none"</c:if></spring:bind> >
> > > > > </c:otherwise>
> > > > > </c:choose>
> > > > > 
> > > > > Thanks
> > > > > 
> > > > > 
> > > > > On Sun, Mar 30, 2014 at 5:51 AM, Lluis Martinez <lluismf@gmail.com>wrote:
> > > > > 
> > > > > > I believe ${identifier == null} is not correct. It should be ${empty
> > > > > > identifier}
> > > > > > 
> > > > > > No idea how it can work though ... perhaps evaluates always false and
> > > > > > executes the c:otherwise branch.
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > On Sat, Mar 29, 2014 at 9:03 PM, Akash Agrawall <
> > > > > > akash.wanted@gmail.com> wrote:
> > > > > > 
> > > > > > > @daniel I used this code snippet and it worked:
> > > > > > > <c:choose>
> > > > > > > <c:when test="${identifier == null}">
> > > > > > > <tr id="voidReasonIdentifierRow-<c:out
> > > > > > > value="${identifier}" />" <spring:bind path="voided"><c:if
> > > > > > > test="${status.value == false}">style="display: \
> > > > > > > none"</c:if></spring:bind> > </c:when>
> > > > > > > <c:otherwise>
> > > > > > > <tr id="voidReasonIdentifierRow-${identifier}"
> > > > > > > <spring:bind path="voided"><c:if test="${status.value ==
> > > > > > > false}">style="display: none"</c:if></spring:bind> >
> > > > > > > </c:otherwise>
> > > > > > > </c:choose>
> > > > > > > Should I go with this?
> > > > > > > 
> > > > > > > Thanks.
> > > > > > > 
> > > > > > > 
> > > > > > > On Sun, Mar 30, 2014 at 1:06 AM, Daniel Kayiwa <
> > > > > > > kayiwadaniel@gmail.com> wrote:
> > > > > > > 
> > > > > > > > Choose a different identifier type which has no check digit.
> > > > > > > > 
> > > > > > > > 
> > > > > > > > On Sat, Mar 29, 2014 at 10:32 PM, Lluis Martinez <lluismf@gmail.com
> > > > > > > > > wrote:
> > > > > > > > 
> > > > > > > > > I'm trying to reproduce it on the demo site but can't, always
> > > > > > > > > gives me some error. Is there a way to have an auto-generated id ?
> > > > > > > > > 
> > > > > > > > > - Invalid check digit for identifier: 1111
> > > > > > > > > - Non-specific error with patient identifier
> > > > > > > > > - Identifier 1111 is not appropriate for validation scheme Luhn
> > > > > > > > > CheckDigit Validator
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > On Sat, Mar 29, 2014 at 8:29 PM, Daniel Kayiwa <
> > > > > > > > > kayiwadaniel@gmail.com> wrote:
> > > > > > > > > 
> > > > > > > > > > Actually i was able to reproduce it.
> > > > > > > > > > 
> > > > > > > > > > @Akash, how about wrapping that in a <c:if test> and check for
> > > > > > > > > > whether the identifier is null?
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > On Sat, Mar 29, 2014 at 10:25 PM, Lluis Martinez <
> > > > > > > > > > lluismf@gmail.com> wrote:
> > > > > > > > > > 
> > > > > > > > > > > In https://issues.openmrs.org/browse/TRUNK-4269 Daniel says
> > > > > > > > > > > that it works well for him, are you sure you don't have \
> > > > > > > > > > > something different ? Perhaps is an Ubuntu only bug of the JSTL \
> > > > > > > > > > > classes (not probable but possible).
> > > > > > > > > > > 
> > > > > > > > > > > Cheers
> > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > On Sat, Mar 29, 2014 at 3:52 PM, Akash Agrawall <
> > > > > > > > > > > akash.wanted@gmail.com> wrote:
> > > > > > > > > > > 
> > > > > > > > > > > > @Lluis,
> > > > > > > > > > > > I don't think it's a syntax error in jsp file because when I
> > > > > > > > > > > > individually try to display: <c:out value="${identifier}" />
> > > > > > > > > > > > also it blocks whole of the page from loading and shows the
> > > > > > > > > > > > same output as shown in screenshot create_patient_error.png .
> > > > > > > > > > > > So, instead of using ${identifier} in place of <c:out
> > > > > > > > > > > > value="${identifier}" /> is there something else that we can \
> > > > > > > > > > > > do? 
> > > > > > > > > > > > Thanks
> > > > > > > > > > > > 
> > > > > > > > > > > > 
> > > > > > > > > > > > On Sat, Mar 29, 2014 at 5:06 PM, Lluis Martinez <
> > > > > > > > > > > > lluismf@gmail.com> wrote:
> > > > > > > > > > > > 
> > > > > > > > > > > > > Another thing to consider: if identifier contains an
> > > > > > > > > > > > > apostrophe (very doubtful ok) you'll have a JS syntax \
> > > > > > > > > > > > > error. It should be escaped to JS too:-)
> > > > > > > > > > > > > 
> > > > > > > > > > > > > 
> > > > > > > > > > > > > 
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > \
> > > > > > > > > > > > > 
> > > > > > > > > > > > > 
> > > > > > > > > > > > > 
> > > > > > > > > > > > > On Sat, Mar 29, 2014 at 12:23 PM, Lluis Martinez <
> > > > > > > > > > > > > lluismf@gmail.com> wrote:
> > > > > > > > > > > > > 
> > > > > > > > > > > > > > I agree, c:out should be null safe ( if ${identifier}
> > > > > > > > > > > > > > evaluates null it should not throw exception, just render \
> > > > > > > > > > > > > > nothing). 
> > > > > > > > > > > > > > 
> > > > > > > > > > > > > > 
> > > > > > > > > > > > > > On Sat, Mar 29, 2014 at 8:07 AM, Okuboyejo Damilola <
> > > > > > > > > > > > > > d.okuboyejo@gmail.com> wrote:
> > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > It seems the JSTL (possibly the version) might be the
> > > > > > > > > > > > > > > culprit.
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > ---------------------------------------
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > Damilola Okuboyejo (MBCS, MCCSA/IITPSA, MIAENG)
> > > > > > > > > > > > > > > ------------------------------
> > > > > > > > > > > > > > > From: Akash Agrawall
> > > > > > > > > > > > > > > Sent: 29/03/2014 08:59 AM
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > To: dev@openmrs.org
> > > > > > > > > > > > > > > Subject: Re: Regarding usage of <c:out
> > > > > > > > > > > > > > > value="${identifier}" /> instead of ${identifier}
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > Sorry for the typo. I meant <c:out \
> > > > > > > > > > > > > > > value="${identifier}" /> 
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > On Sat, Mar 29, 2014 at 12:20 PM, Okuboyejo Damilola <
> > > > > > > > > > > > > > > d.okuboyejo@gmail.com> wrote:
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > Hello Akash,
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > Subtle error
> > > > > > > > > > > > > > > > -------------
> > > > > > > > > > > > > > > > Can you double check that
> > > > > > > > > > > > > > > > <c:out value="${identifier" />       is
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > <c:out value="${identifier"} />
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > I noticed the braces wasn't closed.
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > ---------------------------------------
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > Damilola Okuboyejo (MBCS, MCCSA/IITPSA, MIAENG)
> > > > > > > > > > > > > > > > ------------------------------
> > > > > > > > > > > > > > > > From: Akash Agrawall
> > > > > > > > > > > > > > > > Sent: 29/03/2014 08:24 AM
> > > > > > > > > > > > > > > > To: dev@openmrs.org
> > > > > > > > > > > > > > > > Subject: Re: Regarding usage of <c:out
> > > > > > > > > > > > > > > > value="${identifier}" /> instead of ${identifier}
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > The stack trace can be found here:
> > > > > > > > > > > > > > > > http://pastebin.com/RW0jq2cx
> > > > > > > > > > > > > > > > It is a null pointer exception which gets removed on \
> > > > > > > > > > > > > > > > using ${identifier} instead of <c:out \
> > > > > > > > > > > > > > > > value="${identifier" />. The script in \
> > > > > > > > > > > > > > > > patientForm.jsp doesn't work due to this work, it \
> > > > > > > > > > > > > > > > doesn' t respond to alert("debug") or \
> > > > > > > > > > > > > > > > log.console('debug'). I tried displaying lines in jsp \
> > > > > > > > > > > > > > > > in console but nothing gets displayed if I use <c:out \
> > > > > > > > > > > > > > > > value="${identifier}" /> but it gets displayed in \
> > > > > > > > > > > > > > > > console if I use ${identifier}. Thanks for the reply \
> > > > > > > > > > > > > > > > Lluis. 
> > > > > > > > > > > > > > > > Regards
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > On Sat, Mar 29, 2014 at 4:35 AM, Lluis Martinez <
> > > > > > > > > > > > > > > > lluismf@gmail.com> wrote:
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > What's the problem exactly ? It seems that the JSP \
> > > > > > > > > > > > > > > > > is rendering nothing, does it have compilation \
> > > > > > > > > > > > > > > > > errors ? Any stack trace ? Did you debug the JSP ?
> > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > On Fri, Mar 28, 2014 at 10:55 PM, Akash Agrawall <
> > > > > > > > > > > > > > > > > akash.wanted@gmail.com> wrote:
> > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > > We use the convention:
> > > > > > > > > > > > > > > > > > <c:out value="${identifier}" /> instead of using
> > > > > > > > > > > > > > > > > > ${identifier}
> > > > > > > > > > > > > > > > > > for dealing with XSS attacks in accordance with \
> > > > > > > > > > > > > > > > > > the trunk \
> > > > > > > > > > > > > > > > > > https://issues.openmrs.org/browse/TRUNK-3931 
> > > > > > > > > > > > > > > > > > In this ticket
> > > > > > > > > > > > > > > > > > https://issues.openmrs.org/browse/TRUNK-4269
> > > > > > > > > > > > > > > > > > The usage of this convention in the page
> > > > > > > > > > > > > > > > > > "editPatientIdentifier.jsp" stops whole of the \
> > > > > > > > > > > > > > > > > > page as shown in the screenshot \
> > > > > > > > > > > > > > > > > >                 "create_patient_error.png"
> > > > > > > > > > > > > > > > > > Page: "
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > ".
> > > > > > > > > > > > > > > > > > [Steps to go to this page:
> > > > > > > > > > > > > > > > > > 1. Go to Administration section
> > > > > > > > > > > > > > > > > > 2. Go to Manage Patients
> > > > > > > > > > > > > > > > > > 3. Click on "Create Patient"
> > > > > > > > > > > > > > > > > > 4. Fill in the details and click on "Create \
> > > > > > > > > > > > > > > > > > person" 5. You can see the page. ]
> > > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > > On making the changes as in the pull request
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > \
> > > > > > > > > > > > > > > > > > The view is restored as shown in the screenshot
> > > > > > > > > > > > > > > > > > "create_patient_output.png"
> > > > > > > > > > > > > > > > > > "create_patient_output1.png"
> > > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > > Removing the convention(which helps us deal with \
> > > > > > > > > > > > > > > > > > XSS attacks) for this page doesn't seem to be a \
> > > > > > > > > > > > > > > > > > good option. Is there any other way which can \
> > > > > > > > > > > > > > > > > > help fix this problem? 
> > > > > > > > > > > > > > > > > > Thank You,
> > > > > > > > > > > > > > > > > > Akash Agrawall,
> > > > > > > > > > > > > > > > > > aka_007 on IRC,
> > > > > > > > > > > > > > > > > > aka001 on github
> > > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > > > > > > > > > > > > > Post: dev@openmrs.org | Unsubscribe:
> > > > > > > > > > > > > > > > > > dev+unsubscribe@openmrs.org
> > > > > > > > > > > > > > > > > > Manage your OpenMRS subscriptions at
> > > > > > > > > > > > > > > > > > https://id.openmrs.org/
> > > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > > To unsubscribe from this group and stop receiving \
> > > > > > > > > > > > > > > > > > emails from it, send an email to \
> > > > > > > > > > > > > > > > > > dev+unsubscribe@openmrs.org. 
> > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > > > > > > > > > > > > Post: dev@openmrs.org | Unsubscribe:
> > > > > > > > > > > > > > > > > dev+unsubscribe@openmrs.org
> > > > > > > > > > > > > > > > > Manage your OpenMRS subscriptions at
> > > > > > > > > > > > > > > > > https://id.openmrs.org/
> > > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > > To unsubscribe from this group and stop receiving \
> > > > > > > > > > > > > > > > > emails from it, send an email to \
> > > > > > > > > > > > > > > > > dev+unsubscribe@openmrs.org. 
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > > akash.wanteds
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > > > > > > > > > > > Post: dev@openmrs.org | Unsubscribe:
> > > > > > > > > > > > > > > > dev+unsubscribe@openmrs.org
> > > > > > > > > > > > > > > > Manage your OpenMRS subscriptions at
> > > > > > > > > > > > > > > > https://id.openmrs.org/
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > To unsubscribe from this group and stop receiving \
> > > > > > > > > > > > > > > > emails from it, send an email to \
> > > > > > > > > > > > > > > > dev+unsubscribe@openmrs.org. 
> > > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > > > > > > > > > > > Post: dev@openmrs.org | Unsubscribe:
> > > > > > > > > > > > > > > > dev+unsubscribe@openmrs.org
> > > > > > > > > > > > > > > > Manage your OpenMRS subscriptions at
> > > > > > > > > > > > > > > > https://id.openmrs.org/
> > > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > > To unsubscribe from this group and stop receiving \
> > > > > > > > > > > > > > > > emails from it, send an email to \
> > > > > > > > > > > > > > > > dev+unsubscribe@openmrs.org. 
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > akash.wanteds
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > > > > > > > > > > Post: dev@openmrs.org | Unsubscribe:
> > > > > > > > > > > > > > > dev+unsubscribe@openmrs.org
> > > > > > > > > > > > > > > Manage your OpenMRS subscriptions at \
> > > > > > > > > > > > > > > https://id.openmrs.org/ 
> > > > > > > > > > > > > > > To unsubscribe from this group and stop receiving \
> > > > > > > > > > > > > > > emails from it, send an email to \
> > > > > > > > > > > > > > > dev+unsubscribe@openmrs.org. 
> > > > > > > > > > > > > > > --
> > > > > > > > > > > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > > > > > > > > > > Post: dev@openmrs.org | Unsubscribe:
> > > > > > > > > > > > > > > dev+unsubscribe@openmrs.org
> > > > > > > > > > > > > > > Manage your OpenMRS subscriptions at \
> > > > > > > > > > > > > > > https://id.openmrs.org/ 
> > > > > > > > > > > > > > > To unsubscribe from this group and stop receiving \
> > > > > > > > > > > > > > > emails from it, send an email to \
> > > > > > > > > > > > > > > dev+unsubscribe@openmrs.org. 
> > > > > > > > > > > > > > 
> > > > > > > > > > > > > > 
> > > > > > > > > > > > > --
> > > > > > > > > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > > > > > > > > Post: dev@openmrs.org | Unsubscribe:
> > > > > > > > > > > > > dev+unsubscribe@openmrs.org
> > > > > > > > > > > > > Manage your OpenMRS subscriptions at \
> > > > > > > > > > > > > https://id.openmrs.org/ 
> > > > > > > > > > > > > To unsubscribe from this group and stop receiving emails \
> > > > > > > > > > > > > from it, send an email to dev+unsubscribe@openmrs.org.
> > > > > > > > > > > > > 
> > > > > > > > > > > > 
> > > > > > > > > > > > 
> > > > > > > > > > > > 
> > > > > > > > > > > > --
> > > > > > > > > > > > akash.wanteds
> > > > > > > > > > > > 
> > > > > > > > > > > > --
> > > > > > > > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > > > > > > > Post: dev@openmrs.org | Unsubscribe:
> > > > > > > > > > > > dev+unsubscribe@openmrs.org
> > > > > > > > > > > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > > > > > > > > > > > 
> > > > > > > > > > > > To unsubscribe from this group and stop receiving emails from
> > > > > > > > > > > > it, send an email to dev+unsubscribe@openmrs.org.
> > > > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > --
> > > > > > > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > > > > > > Post: dev@openmrs.org | Unsubscribe: \
> > > > > > > > > > > dev+unsubscribe@openmrs.org Manage your OpenMRS subscriptions \
> > > > > > > > > > > at https://id.openmrs.org/ 
> > > > > > > > > > > To unsubscribe from this group and stop receiving emails from
> > > > > > > > > > > it, send an email to dev+unsubscribe@openmrs.org.
> > > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > --
> > > > > > > > > > If we keep uppermost in our minds the unkind and unjust acts of
> > > > > > > > > > others, we shall find it impossible to love them as Christ has \
> > > > > > > > > > loved us; but if our thoughts dwell upon the wondrous love and \
> > > > > > > > > > pity of Christ for us, the same spirit will flow out to others.
> > > > > > > > > > 
> > > > > > > > > > --
> > > > > > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > > > > > Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org
> > > > > > > > > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > > > > > > > > > 
> > > > > > > > > > To unsubscribe from this group and stop receiving emails from it,
> > > > > > > > > > send an email to dev+unsubscribe@openmrs.org.
> > > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > --
> > > > > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > > > > Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org
> > > > > > > > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > > > > > > > > 
> > > > > > > > > To unsubscribe from this group and stop receiving emails from it,
> > > > > > > > > send an email to dev+unsubscribe@openmrs.org.
> > > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > --
> > > > > > > > If we keep uppermost in our minds the unkind and unjust acts of
> > > > > > > > others, we shall find it impossible to love them as Christ has loved \
> > > > > > > > us; but if our thoughts dwell upon the wondrous love and pity of \
> > > > > > > > Christ for us, the same spirit will flow out to others.
> > > > > > > > 
> > > > > > > > --
> > > > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > > > Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org
> > > > > > > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > > > > > > > 
> > > > > > > > To unsubscribe from this group and stop receiving emails from it,
> > > > > > > > send an email to dev+unsubscribe@openmrs.org.
> > > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > --
> > > > > > > akash.wanteds
> > > > > > > 
> > > > > > > --
> > > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > > Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org
> > > > > > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > > > > > > 
> > > > > > > To unsubscribe from this group and stop receiving emails from it,
> > > > > > > send an email to dev+unsubscribe@openmrs.org.
> > > > > > > 
> > > > > > 
> > > > > > --
> > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org
> > > > > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > > > > > 
> > > > > > To unsubscribe from this group and stop receiving emails from it,
> > > > > > send an email to dev+unsubscribe@openmrs.org.
> > > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > --
> > > > > akash.wanteds
> > > > > 
> > > > > --
> > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org
> > > > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > > > > 
> > > > --
> > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org
> > > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > > > 
> > > > To unsubscribe from this group and stop receiving emails from it, send
> > > > an email to dev+unsubscribe@openmrs.org.
> > > > 
> > > 
> > > --
> > > OpenMRS Developers: http://go.openmrs.org/dev
> > > Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org
> > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > > 
> > --
> > OpenMRS Developers: http://go.openmrs.org/dev
> > Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org
> > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > 
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to dev+unsubscribe@openmrs.org.
> > 
> 
> 
> 
> --
> akash.wanteds
> 
> --
> OpenMRS Developers: http://go.openmrs.org/dev
> Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org
> Manage your OpenMRS subscriptions at https://id.openmrs.org/
> 
> To unsubscribe from this group and stop receiving emails from it, send an
> email to dev+unsubscribe@openmrs.org.
> 

-- 
OpenMRS Developers: http://go.openmrs.org/dev
Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org
Manage your OpenMRS subscriptions at https://id.openmrs.org/

To unsubscribe from this group and stop receiving emails from it, send an email to \
dev+unsubscribe@openmrs.org.


[Attachment #3 (text/html)]

<div dir="ltr">Are you sure it&#39;s not a bug in your code? The void checkbox is \
also not visible.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On \
Tue, Apr 1, 2014 at 12:26 AM, Akash Agrawall <span dir="ltr">&lt;<a \
href="mailto:akash.wanted@gmail.com" \
target="_blank">akash.wanted@gmail.com</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">@Lluis Thanks for this idea but in openmrs \
version 1.11 we don&#39;t have a space for voidReason.(Screenshot attached)<br> \
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Mar 30, 2014 \
at 9:08 PM, Darius Jazayeri <span dir="ltr">&lt;<a href="mailto:djazayeri@gmail.com" \
target="_blank">djazayeri@gmail.com</a>&gt;</span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><p dir="ltr">That makes sense, and also, can we check to make \
sure PatientIdentifier.toString() can&#39;t throw an NPE?</p>


<p dir="ltr">-Darius (by phone)</p><div><div>
<div class="gmail_quote">On Mar 30, 2014 10:10 AM, &quot;Lluis Martinez&quot; &lt;<a \
href="mailto:lluismf@gmail.com" target="_blank">lluismf@gmail.com</a>&gt; wrote:<br \
type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">


<div dir="ltr">Currently the void reason row ID is made up by concatenating the \
identifier (which can be null). Why not just using the index of the identifiers \
array, as the void reason input does? (see image)<div><br></div>



<div>Instead of <span style="font-family:Consolas,&#39;Lucida \
Console&#39;,monospace;font-size:12px;white-space:pre-wrap">voidReasonIdentifierRow-1007HK \
the DOM id would be </span><span style="font-family:Consolas,&#39;Lucida \
Console&#39;,monospace;font-size:12px;white-space:pre-wrap">voidReasonIdentifierRow[0]</span></div>




<div><span style="font-family:Consolas,&#39;Lucida \
Console&#39;,monospace;font-size:12px;white-space:pre-wrap"><br></span></div><div><span \
style="font-family:Consolas,&#39;Lucida \
Console&#39;,monospace;font-size:12px;white-space:pre-wrap">PS: the behaviour of this \
form is fragile, for instance if multiple identifiers are added and some error occurs \
all but one disappear</span></div>



<div><span style="font-family:Consolas,&#39;Lucida \
Console&#39;,monospace;font-size:12px;white-space:pre-wrap"><br></span></div></div><div \
class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Mar 30, 2014 at 3:54 AM, \
Darius Jazayeri <span dir="ltr">&lt;<a href="mailto:djazayeri@gmail.com" \
target="_blank">djazayeri@gmail.com</a>&gt;</span> wrote:<br>



<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><p dir="ltr">We shouldn&#39;t have to do this, though. The \
c-rt tag libraries do not typically fail in this case.</p> <p dir="ltr">Can we find \
out what the real problem is rather than wrapping excessive error checking around \
what is just a print statement?</p> <p dir="ltr">-Darius (by phone)</p><div><div>
<div class="gmail_quote">On Mar 29, 2014 8:30 PM, &quot;Akash Agrawall&quot; &lt;<a \
href="mailto:akash.wanted@gmail.com" target="_blank">akash.wanted@gmail.com</a>&gt; \
wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">




<div dir="ltr"><div><div>Sorry for that. Yaa this was the case I guess. Changed it \
to:<br>&lt;c:choose&gt;<br>        &lt;c:when test=&quot;${empty \
identifier}&quot;&gt;<br>            &lt;tr \
id=&quot;voidReasonIdentifierRow-&lt;c:out value=&quot;${identifier}&quot; \
/&gt;&quot; &lt;spring:bind path=&quot;voided&quot;&gt;&lt;c:if \
test=&quot;${status.value == false}&quot;&gt;style=&quot;display: \
none&quot;&lt;/c:if&gt;&lt;/spring:bind&gt; &gt;<br>





        &lt;/c:when&gt;<br>        &lt;c:otherwise&gt;<br>            &lt;tr \
id=&quot;voidReasonIdentifierRow-${identifier}&quot; &lt;spring:bind \
path=&quot;voided&quot;&gt;&lt;c:if test=&quot;${status.value == \
false}&quot;&gt;style=&quot;display: none&quot;&lt;/c:if&gt;&lt;/spring:bind&gt; \
&gt;<br>





        &lt;/c:otherwise&gt;<br>    \
&lt;/c:choose&gt;<br></div><br></div>Thanks<br></div><div \
class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Mar 30, 2014 at 5:51 AM, \
Lluis Martinez <span dir="ltr">&lt;<a href="mailto:lluismf@gmail.com" \
target="_blank">lluismf@gmail.com</a>&gt;</span> wrote:<br>





<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><span \
style="font-family:arial,sans-serif;font-size:13px">I</span><span \
style="font-family:arial,sans-serif;font-size:13px"> believe ${identifier == null} is \
not correct. It should be </span><span \
style="background-color:transparent;color:rgb(0,0,255);font-family:Consolas,Menlo,Monaco,&#39;Lucida \
Console&#39;,&#39;Liberation Mono&#39;,&#39;DejaVu Sans Mono&#39;,&#39;Bitstream Vera \
Sans Mono&#39;,&#39;Courier \
New&#39;,monospace,serif;white-space:inherit;font-size:14px;line-height:17.804800033569336px">${empty \
identifier}</span><div>






<font color="#0000ff" face="Consolas, Menlo, Monaco, Lucida Console, Liberation Mono, \
DejaVu Sans Mono, Bitstream Vera Sans Mono, Courier New, monospace, serif"><span \
style="font-size:14px;line-height:17.804800033569336px"><br>






</span></font></div><div><span style="font-family:arial,sans-serif;font-size:13px">No \
idea how it can work though ... perhaps evaluates always false and executes the \
c:otherwise branch. </span></div><div><font face="arial, sans-serif"><br>






</font></div><div><div><span \
style="background-color:transparent;color:rgb(0,0,255);font-family:Consolas,Menlo,Monaco,&#39;Lucida \
Console&#39;,&#39;Liberation Mono&#39;,&#39;DejaVu Sans Mono&#39;,&#39;Bitstream Vera \
Sans Mono&#39;,&#39;Courier \
New&#39;,monospace,serif;white-space:inherit;font-size:14px;line-height:17.804800033569336px"><br>







</span></div><div><span \
style="background-color:transparent;color:rgb(0,0,255);font-family:Consolas,Menlo,Monaco,&#39;Lucida \
Console&#39;,&#39;Liberation Mono&#39;,&#39;DejaVu Sans Mono&#39;,&#39;Bitstream Vera \
Sans Mono&#39;,&#39;Courier \
New&#39;,monospace,serif;white-space:inherit;font-size:14px;line-height:17.804800033569336px"><br>







</span></div></div></div><div><div><div class="gmail_extra"><br><br><div \
class="gmail_quote">On Sat, Mar 29, 2014 at 9:03 PM, Akash Agrawall <span \
dir="ltr">&lt;<a href="mailto:akash.wanted@gmail.com" \
target="_blank">akash.wanted@gmail.com</a>&gt;</span> wrote:<br>






<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div>@daniel I used this code snippet and it \
worked:<br>&lt;c:choose&gt;<br>        &lt;c:when test=&quot;${identifier == \
null}&quot;&gt;<br>






            &lt;tr id=&quot;voidReasonIdentifierRow-&lt;c:out \
value=&quot;${identifier}&quot; /&gt;&quot; &lt;spring:bind \
path=&quot;voided&quot;&gt;&lt;c:if test=&quot;${status.value == \
false}&quot;&gt;style=&quot;display: none&quot;&lt;/c:if&gt;&lt;/spring:bind&gt; \
&gt;<br>







        &lt;/c:when&gt;<br>        &lt;c:otherwise&gt;<br>            &lt;tr \
id=&quot;voidReasonIdentifierRow-${identifier}&quot; &lt;spring:bind \
path=&quot;voided&quot;&gt;&lt;c:if test=&quot;${status.value == \
false}&quot;&gt;style=&quot;display: none&quot;&lt;/c:if&gt;&lt;/spring:bind&gt; \
&gt;<br>







        &lt;/c:otherwise&gt;<br>&lt;/c:choose&gt;<br></div><div>Should I go with \
this?<br><br></div>Thanks.<br></div><div><div><div class="gmail_extra"><br><br><div \
class="gmail_quote">On Sun, Mar 30, 2014 at 1:06 AM, Daniel Kayiwa <span \
dir="ltr">&lt;<a href="mailto:kayiwadaniel@gmail.com" \
target="_blank">kayiwadaniel@gmail.com</a>&gt;</span> wrote:<br>







<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">Choose a different identifier type which has \
no check digit.<br></div><div><div> <div class="gmail_extra"><br><br><div \
class="gmail_quote">On Sat, Mar 29, 2014 at 10:32 PM, Lluis Martinez <span \
dir="ltr">&lt;<a href="mailto:lluismf@gmail.com" \
target="_blank">lluismf@gmail.com</a>&gt;</span> wrote:<br>








<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">I&#39;m trying to reproduce it on the demo \
site but can&#39;t, always gives me some error. Is there a way to have an \
auto-generated id ? <div>








<br></div><div>- <span \
style="font-size:14px;background-color:rgb(255,182,193);font-family:Verdana,&#39;Lucida \
Grande&#39;,&#39;Trebuchet MS&#39;,Arial,sans-serif">Invalid check digit for \
identifier: 1111</span></div> <div><span \
style="font-size:14px;background-color:rgb(255,182,193);font-family:Verdana,&#39;Lucida \
Grande&#39;,&#39;Trebuchet MS&#39;,Arial,sans-serif">- </span><span \
style="font-size:14px;background-color:rgb(255,182,193);font-family:Verdana,&#39;Lucida \
Grande&#39;,&#39;Trebuchet MS&#39;,Arial,sans-serif">Non-specific error with patient \
identifier</span></div>









<div><span style="font-size:14px;background-color:rgb(255,182,193);font-family:Verdana,&#39;Lucida \
Grande&#39;,&#39;Trebuchet MS&#39;,Arial,sans-serif">- Identifier 1111 is not \
appropriate for validation scheme Luhn CheckDigit Validator</span><span \
style="font-size:14px;background-color:rgb(255,182,193);font-family:Verdana,&#39;Lucida \
Grande&#39;,&#39;Trebuchet MS&#39;,Arial,sans-serif"><br>









</span></div><div><span \
style="font-size:14px;background-color:rgb(255,182,193);font-family:Verdana,&#39;Lucida \
Grande&#39;,&#39;Trebuchet \
MS&#39;,Arial,sans-serif"><br></span></div></div><div><div> <div class="gmail_extra">
<br><br><div class="gmail_quote">On Sat, Mar 29, 2014 at 8:29 PM, Daniel Kayiwa <span \
dir="ltr">&lt;<a href="mailto:kayiwadaniel@gmail.com" \
target="_blank">kayiwadaniel@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">









<div dir="ltr"><div>Actually i was able to reproduce it.<br><br></div>@Akash, how \
about wrapping that in a &lt;c:if test&gt; and check for whether the identifier is \
null?<br></div><div class="gmail_extra"><div><div> <br><br><div class="gmail_quote">
On Sat, Mar 29, 2014 at 10:25 PM, Lluis Martinez <span dir="ltr">&lt;<a \
href="mailto:lluismf@gmail.com" target="_blank">lluismf@gmail.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">










<div dir="ltr">In <a href="https://issues.openmrs.org/browse/TRUNK-4269" \
target="_blank">https://issues.openmrs.org/browse/TRUNK-4269</a> Daniel says that it \
works well for him, are you sure you don&#39;t have something different ? Perhaps is \
an Ubuntu only bug of the JSTL classes (not probable but possible).<div>











<div><br></div><div>Cheers</div></div></div><div><div><div \
class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Mar 29, 2014 at 3:52 PM, \
Akash Agrawall <span dir="ltr">&lt;<a href="mailto:akash.wanted@gmail.com" \
target="_blank">akash.wanted@gmail.com</a>&gt;</span> wrote:<br>











<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div><div><div><div><div>@Lluis,<br></div>I \
don&#39;t think it&#39;s a syntax error in jsp file because when I individually try \
to display: &lt;c:out value=&quot;${identifier}&quot; /&gt;<br>











</div>also it blocks whole of the page from loading and shows the same output as \
shown in screenshot create_patient_error.png .<br> </div>So, instead of using \
${identifier} in place of &lt;c:out value=&quot;${identifier}&quot; /&gt; is there \
something else that we can do?<br></div><br></div>Thanks<br></div><div \
class="gmail_extra"><br><br><div class="gmail_quote">












On Sat, Mar 29, 2014 at 5:06 PM, Lluis Martinez <span dir="ltr">&lt;<a \
href="mailto:lluismf@gmail.com" target="_blank">lluismf@gmail.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">












<div dir="ltr">Another thing to consider: if identifier contains an apostrophe (very \
doubtful ok) you&#39;ll have a JS syntax error. It should be escaped to JS \
too:-)<div><br></div><div><pre style="font-family:Consolas,&#39;Liberation \
Mono&#39;,Courier,monospace;font-size:12px;margin-top:0px;margin-bottom:0px;color:rgb(51,51,51)">



onClick=&quot;toggleLayer(&#39;voidReasonIdentifierRow-<span \
style="color:rgb(0,0,0);background-color:rgb(170,255,170)">${identifier}</span>&#39;); \
if (voidedBoxClicked) voidedBoxClicked(this); &quot;</pre></div> </div><div><div><div \
class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Mar 29, 2014 at 12:23 \
PM, Lluis Martinez <span dir="ltr">&lt;<a href="mailto:lluismf@gmail.com" \
target="_blank">lluismf@gmail.com</a>&gt;</span> wrote:<br>













<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">I agree, c:out should be null safe ( if \
${identifier} evaluates null it should not throw exception, just render \
nothing).<div>













<br></div></div><div><div><div class="gmail_extra"><br><br><div \
class="gmail_quote">On Sat, Mar 29, 2014 at 8:07 AM, Okuboyejo Damilola <span \
dir="ltr">&lt;<a href="mailto:d.okuboyejo@gmail.com" \
target="_blank">d.okuboyejo@gmail.com</a>&gt;</span> wrote:<br>














<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div><div><div \
style="font-family:Calibri,sans-serif;font-size:11pt">It seems the JSTL (possibly the \
version) might be the culprit.<div>














<br>
<br><br>---------------------------------------<br><br>Damilola Okuboyejo (MBCS, \
MCCSA/IITPSA, MIAENG)<br></div></div></div><hr><span \
style="font-family:Tahoma,sans-serif;font-size:10pt;font-weight:bold">From: \
</span><span style="font-family:Tahoma,sans-serif;font-size:10pt">Akash \
Agrawall</span><br>















<span style="font-family:Tahoma,sans-serif;font-size:10pt;font-weight:bold">Sent: \
</span><span style="font-family:Tahoma,sans-serif;font-size:10pt">29/03/2014 08:59 \
AM</span><div><div><br><span \
style="font-family:Tahoma,sans-serif;font-size:10pt;font-weight:bold">To: \
</span><span style="font-family:Tahoma,sans-serif;font-size:10pt"><a \
href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a></span><br>















<span style="font-family:Tahoma,sans-serif;font-size:10pt;font-weight:bold">Subject: \
</span><span style="font-family:Tahoma,sans-serif;font-size:10pt">Re: Regarding usage \
of &lt;c:out value=&quot;${identifier}&quot; /&gt; instead of \
${identifier}</span><br>















<br></div></div></div><div><div><div dir="ltr"><div>Sorry for the typo. I meant \
&lt;c:out value=&quot;${identifier}&quot; /&gt;<br></div></div><div \
class="gmail_extra"><br><br><div class="gmail_quote"> On Sat, Mar 29, 2014 at 12:20 \
PM, Okuboyejo Damilola <span dir="ltr">&lt;<a href="mailto:d.okuboyejo@gmail.com" \
target="_blank">d.okuboyejo@gmail.com</a>&gt;</span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div><div><div \
style="font-family:Calibri,sans-serif;font-size:11pt">Hello Akash,<br><br>Subtle \
error<br>-------------<br>
















Can you double check that <br>
&lt;c:out value=&quot;${identifier&quot; /&gt;       is<div><br>&lt;c:out \
value=&quot;${identifier&quot;} /&gt;<br><br></div>I noticed the braces wasn&#39;t \
closed.<br><br><br><br>---------------------------------------<br>
















<br>Damilola Okuboyejo (MBCS, MCCSA/IITPSA, MIAENG)<br>
</div></div><hr><span \
style="font-family:Tahoma,sans-serif;font-size:10pt;font-weight:bold">From: \
</span><span style="font-family:Tahoma,sans-serif;font-size:10pt">Akash \
Agrawall</span><br><span \
style="font-family:Tahoma,sans-serif;font-size:10pt;font-weight:bold">Sent: \
</span><span style="font-family:Tahoma,sans-serif;font-size:10pt">29/03/2014 08:24 \
AM</span><br>

















<span style="font-family:Tahoma,sans-serif;font-size:10pt;font-weight:bold">To: \
</span><span style="font-family:Tahoma,sans-serif;font-size:10pt"><a \
href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a></span><br>
















<span style="font-family:Tahoma,sans-serif;font-size:10pt;font-weight:bold">Subject: \
</span><span style="font-family:Tahoma,sans-serif;font-size:10pt">Re: Regarding usage \
of &lt;c:out value=&quot;${identifier}&quot; /&gt; instead of \
${identifier}</span><br>

















<br></div><div><div><div dir="ltr"><div><div><div><div><div>The stack trace can be \
found here:<br><a href="http://pastebin.com/RW0jq2cx" \
target="_blank">http://pastebin.com/RW0jq2cx</a><br></div>

It is a null pointer exception which gets removed on using ${identifier} instead of \
&lt;c:out value=&quot;${identifier&quot; /&gt;.<br>

</div>The script in patientForm.jsp doesn&#39;t work due to this work, it doesn&#39; \
t respond to alert(&quot;debug&quot;) or log.console(&#39;debug&#39;). <br></div>I \
tried displaying lines in jsp in console but nothing gets displayed if I use \
&lt;c:out value=&quot;${identifier}&quot; /&gt; but it gets displayed in console if I \
use ${identifier}.<br>


















</div>Thanks for the reply Lluis.<br><br></div>Regards<br></div><div \
class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Mar 29, 2014 at 4:35 AM, \
Lluis Martinez <span dir="ltr">&lt;<a href="mailto:lluismf@gmail.com" \
target="_blank">lluismf@gmail.com</a>&gt;</span> wrote:<br>


















<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">What&#39;s the problem exactly ? It seems that \
the JSP is rendering nothing, does it have compilation errors ? Any stack trace ? Did \
you debug the JSP ?</div>


















<div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>
On Fri, Mar 28, 2014 at 10:55 PM, Akash Agrawall <span dir="ltr">&lt;<a \
href="mailto:akash.wanted@gmail.com" \
target="_blank">akash.wanted@gmail.com</a>&gt;</span> \
wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">


















<div><div>
<div dir="ltr"><div><div><div><div>We use the convention:<br></div>&lt;c:out \
value=&quot;${identifier}&quot; /&gt; instead of using ${identifier}<br></div>for \
dealing with XSS attacks in accordance with the trunk <a \
href="https://issues.openmrs.org/browse/TRUNK-3931" \
target="_blank">https://issues.openmrs.org/browse/TRUNK-3931</a><br>




















<br></div><div>In this ticket <a href="https://issues.openmrs.org/browse/TRUNK-4269" \
target="_blank">https://issues.openmrs.org/browse/TRUNK-4269</a><br></div>The usage \
of this convention in the page &quot;editPatientIdentifier.jsp&quot; stops whole of \
the page as shown in the screenshot &quot;create_patient_error.png&quot;<br>




















Page: &quot;<a href="http://localhost:8080/openmrs/admin/patients/patient.form?addName=testit&amp;addBirthdate=23/02/2014&amp;addAge=&amp;addGender=M" \
target="_blank">http://localhost:8080/openmrs/admin/patients/patient.form?addName=testit&amp;addBirthdate=23/02/2014&amp;addAge=&amp;addGender=M</a>&quot;.<br>





















</div><div>[Steps to go to this page:<br></div><div>      1. Go to Administration \
section<br></div><div>      2. Go to Manage Patients<br></div><div>      3. Click on \
&quot;Create Patient&quot;<br></div><div>      4. Fill in the details and click on \
&quot;Create person&quot;<br>




















</div><div>      5. You can see the page. ]<br><br></div><div>On making the changes \
as in the pull request <br><a \
href="https://github.com/openmrs/openmrs-core/pull/826/files" \
target="_blank">https://github.com/openmrs/openmrs-core/pull/826/files</a><br>




















</div><div>The view is restored as shown in the \
screenshot<br></div><div>&quot;create_patient_output.png&quot;<br></div><div>&quot;create_patient_output1.png&quot;<br><br></div><div>Removing \
the convention(which helps us deal with XSS attacks) for this page doesn&#39;t seem \
to be a good option.<br>




















</div><div>Is there any other way which can help fix this \
problem?<br></div><div><br></div><div>Thank You,<br></div><div>Akash \
Agrawall,<br>aka_007 on IRC,<br>aka001 on github<span><font color="#888888"><br> \
</font></span></div></div></div></div><span><font color="#888888"><span><font \
color="#888888">

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<br> \
</font></span></font></span></blockquote></div><span><font \
color="#888888"><br></font></span></div><span><font color="#888888">

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<br> \
</font></span></blockquote></div><br><br clear="all"><br>-- <br>akash.wanteds </div>

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<br>

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<br> \
</div></div></blockquote></div><br><br clear="all"><br>-- <br>akash.wanteds </div>

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<br>

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<br> \
</div></div></blockquote></div><br></div> </div></div></blockquote></div><br></div>

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<span><font color="#888888"><br>

</font></span></div></div></blockquote></div><span><font color="#888888"><br><br \
clear="all"><br>-- <br>akash.wanteds </font></span></div><span><font color="#888888">

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<br> \
</font></span></blockquote></div><br></div>

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<br> \
</div></div></blockquote></div><br><br clear="all"><br>-- <br></div></div>If we keep \
uppermost in our minds the unkind and unjust acts of others, we shall find it \
impossible to love them as Christ has loved us; but if our thoughts dwell upon the \
wondrous love and pity of Christ for us, the same spirit will flow out to others. \
</div><div><div>

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<br> \
</div></div></blockquote></div><br></div>

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<br> \
</div></div></blockquote></div><br><br clear="all"><br>-- <br>If we keep uppermost in \
our minds the unkind and unjust acts of others, we shall find it impossible to love \
them as Christ has loved us; but if our thoughts dwell upon the wondrous love and \
pity of Christ for us, the same spirit will flow out to others. </div>

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<br> \
</div></div></blockquote></div><br><br clear="all"><br>-- <br>akash.wanteds </div>

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<br> \
</div></div></blockquote></div><br></div>

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<br> \
</div></div></blockquote></div><br><br clear="all"><br>-- <br>akash.wanteds </div>

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br> \
</blockquote></div>

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<br> \
</div></div></blockquote></div><br></div>

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br> \
</blockquote></div>

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<span class="HOEnZb"><font \
color="#888888"><br>

</font></span></div></div></blockquote></div><span class="HOEnZb"><font \
color="#888888"><br><br clear="all"><br>-- <br>akash.wanteds \
</font></span></div><span class="HOEnZb"><font color="#888888">

<p></p>

-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
                target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br>

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a>.<br> \
</font></span></blockquote></div><br></div>

<p></p>

-- <br />
OpenMRS Developers: <a \
                href="http://go.openmrs.org/dev">http://go.openmrs.org/dev</a><br />
Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org<br />
Manage your OpenMRS subscriptions at <a \
href="https://id.openmrs.org/">https://id.openmrs.org/</a><br />

<p></p>

To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org">dev+unsubscribe@openmrs.org</a>.<br />



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic