[prev in list] [next in list] [prev in thread] [next in thread]
List: openmrs-dev
Subject: Re: OrderTypes and Concept Classes
From: Darius Jazayeri <darius () openmrs ! org>
Date: 2014-03-26 20:15:28
Message-ID: CAA-nHnd9cEiJ=q6QNk-ToZ89pk_r0RrnWmyD_HKu=TQpq+V=fQ () mail ! gmail ! com
[Download RAW message or body]
I would prefer if we explicitly set this. It seems annoying to
(occasionally) have to go to ancestor order types to get the java class.
Would this gain us something?
-Darius
On Wed, Mar 26, 2014 at 4:09 PM, Wyclif Luyima <wyclif@openmrs.org> wrote:
> I was aware we talked about the first one, we just decided on the design
> call to bring this to the devlist to make sure others agree that it is
> unnecessary.
>
> How about making order_type.java_class_name nullable, i.e inherited if the
> parent order type has it set?
>
> Wyclif
>
>
> On Wed, Mar 26, 2014 at 3:56 PM, Darius Jazayeri <darius@openmrs.org>wrote:
>
> > I believe we said that if a dev sets order.orderType, then we trust them
> > to have gotten it right. So I think we should *not* enforce the first
> > validation you mention.
> >
> > I *do* think we should enforce the second validation.
> >
> > -Darius
> >
> >
> > On Wed, Mar 26, 2014 at 3:13 PM, Wyclif Luyima <wyclif@openmrs.org>wrote:
> >
> > > Hi,
> > >
> > > Does it sound fine to enforce these rules in the Order entry API?
> > >
> > > - order.concept.conceptClass should be in order.orderType.conceptClasses
> > > respecting order type hierarchy i.e the check should happen recursively for
> > > all ancestors if not found on the immediate order type.
> > > - order.orderType.javaClassName should match order.class.name, taking
> > > into consideration class hierarchy.
> > >
> > > The orders_type.java_class_name column is required, shouldn't this be
> > > nullable, assuming that sub types inherit the java class of the parent.
> > >
> > > Wyclif
> > > .
> > > --
> > > Wyclif Luyima
> > > Regenstrief Institute Inc.
> > >
> > > Confidentiality Notice: The contents of this message and any files
> > > transmitted with it may contain confidential and/or privileged information
> > > and are intended solely for the use of the named addressee(s).
> > > Additionally, the information contained herein may have been disclosed to
> > > you from medical records with confidentiality protected by federal and
> > > state laws. Federal regulations and State laws prohibit you from making
> > > further disclosure of such information without the specific written consent
> > > of the person to whom the information pertains or as otherwise permitted by
> > > such regulations. A general authorization for the release of medical or
> > > other information is not sufficient for this purpose.
> > >
> > > If you have received this message in error, please notify the sender by
> > > return e-mail and delete the original message. Any retention, disclosure,
> > > copying, distribution or use of this information by anyone other than the
> > > intended recipient is strictly prohibited.
> > >
> > > --
> > > OpenMRS Developers: http://go.openmrs.org/dev
> > > Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org
> > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > >
> >
> > --
> > OpenMRS Developers: http://go.openmrs.org/dev
> > Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org
> > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> >
>
>
>
> --
> Wyclif Luyima
> Regenstrief Institute Inc.
>
> Confidentiality Notice: The contents of this message and any files
> transmitted with it may contain confidential and/or privileged information
> and are intended solely for the use of the named addressee(s).
> Additionally, the information contained herein may have been disclosed to
> you from medical records with confidentiality protected by federal and
> state laws. Federal regulations and State laws prohibit you from making
> further disclosure of such information without the specific written consent
> of the person to whom the information pertains or as otherwise permitted by
> such regulations. A general authorization for the release of medical or
> other information is not sufficient for this purpose.
>
> If you have received this message in error, please notify the sender by
> return e-mail and delete the original message. Any retention, disclosure,
> copying, distribution or use of this information by anyone other than the
> intended recipient is strictly prohibited.
>
> --
> OpenMRS Developers: http://go.openmrs.org/dev
> Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org
> Manage your OpenMRS subscriptions at https://id.openmrs.org/
>
--
OpenMRS Developers: http://go.openmrs.org/dev
Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org
Manage your OpenMRS subscriptions at https://id.openmrs.org/
To unsubscribe from this group and stop receiving emails from it, send an email to \
dev+unsubscribe@openmrs.org.
[Attachment #3 (text/html)]
<div dir="ltr">I would prefer if we explicitly set this. It seems annoying to \
(occasionally) have to go to ancestor order types to get the java class. Would this \
gain us something?<div><div><br></div><div>-Darius</div></div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Mar 26, 2014 \
at 4:09 PM, Wyclif Luyima <span dir="ltr"><<a href="mailto:wyclif@openmrs.org" \
target="_blank">wyclif@openmrs.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div>I was aware we talked about the first \
one, we just decided on the design call to bring this to the devlist to make sure \
others agree that it is unnecessary.<br>
<br>How about making order_type.java_class_name nullable, i.e inherited if the parent \
order type has it set?<span class="HOEnZb"><font color="#888888"><br> \
<br></font></span></div><span class="HOEnZb"><font \
color="#888888">Wyclif<br></font></span></div><div class="HOEnZb"><div \
class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Mar 26, \
2014 at 3:56 PM, Darius Jazayeri <span dir="ltr"><<a \
href="mailto:darius@openmrs.org" target="_blank">darius@openmrs.org</a>></span> \
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">I believe we said that if a dev sets \
order.orderType, then we trust them to have gotten it right. So I think we should \
<i>not</i> enforce the first validation you mention.<div>
<br></div><div>I <i>do</i> think we should enforce the second validation.</div>
<div><div><br></div><div>-Darius</div></div></div><div \
class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Wed, Mar 26, 2014 \
at 3:13 PM, Wyclif Luyima <span dir="ltr"><<a href="mailto:wyclif@openmrs.org" \
target="_blank">wyclif@openmrs.org</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><div><div><div \
dir="ltr"><div><div><div>Hi,<br><br></div>Does it sound fine to enforce these rules \
in the Order entry API?<br>
<br>
- order.concept.conceptClass should be in order.orderType.conceptClasses respecting \
order type hierarchy i.e the check should happen recursively for all ancestors if not \
found on the immediate order type.<br>
- order.orderType.javaClassName should match <a href="http://order.class.name" \
target="_blank">order.class.name</a>, taking into consideration class \
hierarchy.<br><br></div>The orders_type.java_class_name column is required, \
shouldn't this be nullable, assuming that sub types inherit the java class of the \
parent.<br>
<br></div>Wyclif<br clear="all"><div><div><div><div>.<span><font \
color="#888888"><br>-- <br><span style="background-color:rgb(51,102,255)"><span \
style="color:rgb(255,102,102)"><span \
style="font-size:7.5pt;font-family:"Arial","sans-serif""><span \
style="background-color:rgb(255,255,255)"><span style="color:rgb(51,102,255)">Wyclif \
Luyima<br>
Regenstrief Institute Inc.<br><br>
</span></span></span><span style="color:rgb(204,0,0)"><span \
style="font-size:7.5pt;font-family:"Arial","sans-serif""><span \
style="background-color:rgb(255,255,255)"><span \
style="color:rgb(51,102,255)">Confidentiality Notice: The contents of this message \
and any files transmitted with it may contain confidential and/or privileged \
information and are intended solely for the
use of the named addressee(s). Additionally, the information contained
herein may have been disclosed to you from medical records with
confidentiality protected by federal and state laws. Federal regulations
and State laws prohibit you from making further
disclosure of such information without the specific written consent of
the person to whom the information pertains or as otherwise permitted by
such regulations. A general authorization for the release of medical or
other information is not sufficient for
this purpose.<br>
<br>
If you have received this message in error, please notify the sender by
return e-mail and delete the original message. Any retention,
disclosure, copying, distribution or use of this information by anyone
other than the intended recipient is strictly prohibited.
</span><span></span></span></span></span></span></span>
</font></span></div></div></div></div></div></div></div><span><font \
color="#888888"><span><font color="#888888">
<p></p>
-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br> \
</font></span></font></span></blockquote></div><span><font \
color="#888888"><br></font></span></div><span><font color="#888888">
<p></p>
-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br> \
</font></span></blockquote></div><br><br clear="all"><br>-- <br><span \
style="background-color:rgb(51,102,255)"><span style="color:rgb(255,102,102)"><span \
style="font-size:7.5pt;font-family:"Arial","sans-serif""><span \
style="background-color:rgb(255,255,255)"><span style="color:rgb(51,102,255)">Wyclif \
Luyima<br>
Regenstrief Institute Inc.<br><br>
</span></span></span><span style="color:rgb(204,0,0)"><span \
style="font-size:7.5pt;font-family:"Arial","sans-serif""><span \
style="background-color:rgb(255,255,255)"><span \
style="color:rgb(51,102,255)">Confidentiality Notice: The contents of this message \
and any files transmitted with it may contain confidential and/or privileged \
information and are intended solely for the
use of the named addressee(s). Additionally, the information contained
herein may have been disclosed to you from medical records with
confidentiality protected by federal and state laws. Federal regulations
and State laws prohibit you from making further
disclosure of such information without the specific written consent of
the person to whom the information pertains or as otherwise permitted by
such regulations. A general authorization for the release of medical or
other information is not sufficient for
this purpose.<br>
<br>
If you have received this message in error, please notify the sender by
return e-mail and delete the original message. Any retention,
disclosure, copying, distribution or use of this information by anyone
other than the intended recipient is strictly prohibited.
</span><span></span></span></span></span></span></span>
</div>
<p></p>
-- <br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org" target="_blank">dev@openmrs.org</a> | \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org" \
target="_blank">dev+unsubscribe@openmrs.org</a><br> Manage your OpenMRS subscriptions \
at <a href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br> \
</div></div></blockquote></div><br></div>
<p></p>
-- <br />
OpenMRS Developers: <a \
href="http://go.openmrs.org/dev">http://go.openmrs.org/dev</a><br />
Post: dev@openmrs.org | Unsubscribe: dev+unsubscribe@openmrs.org<br />
Manage your OpenMRS subscriptions at <a \
href="https://id.openmrs.org/">https://id.openmrs.org/</a><br />
<p></p>
To unsubscribe from this group and stop receiving emails from it, send an email to <a \
href="mailto:dev+unsubscribe@openmrs.org">dev+unsubscribe@openmrs.org</a>.<br />
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic