[prev in list] [next in list] [prev in thread] [next in thread]
List: openmrs-dev
Subject: Re: Workarea configuration for module
From: Rafal Korytkowski <rafal () openmrs ! org>
Date: 2012-12-31 14:56:24
Message-ID: CAKNp=UO7EWuroNGj6R0Wim6z9ixwk=cJhJTcup-fOFOk-Uz-yQ () mail ! gmail ! com
[Download RAW message or body]
Ha! Done. Thanks Lluis!
-Rafał
On 31 December 2012 15:49, Lluis Martinez <lluismf@gmail.com> wrote:
> Not yet, but will do if you put REPORT-460 in Ready to work status :-)
>
> Cheers
>
> On Sun, Dec 30, 2012 at 6:03 PM, Rafal Korytkowski <rafal@openmrs.org>
> wrote:
> > Lluis, did you send a pull request with your fixed tests? :-)
> >
> >
> > -Rafał
> >
> >
> > On 28 December 2012 20:59, Lluis Martinez <lluismf@gmail.com> wrote:
> > >
> > > Hi Darius,
> > >
> > > I corrected the failing unit tests and the omod file was generated
> > > after executing mvn install.
> > >
> > > Thanks!
> > >
> > > On Fri, Dec 28, 2012 at 7:09 PM, Darius Jazayeri <darius@openmrs.org>
> > > wrote:
> > > > Hi Lluis,
> > > >
> > > > I'm not 100% sure of this, but I believe that the
> maven-openmrs-plugin,
> > > > in
> > > > its package-module goal (see omod/pom.xml, or see its source here) is
> > > > what
> > > > generates the omod whenever you do a mvn package or mvn install on the
> > > > module's maven project.
> > > >
> > > > Effectively an omod is just a jar file with a different file
> extension,
> > > > and
> > > > some extra assumptions about its directory structure.
> > > >
> > > > -Darius
> > > >
> > > >
> > > > On Fri, Dec 28, 2012 at 9:40 AM, Lluis Martinez <lluismf@gmail.com>
> > > > wrote:
> > > > >
> > > > > Hi Michael,
> > > > >
> > > > > These are the failing unit tests:
> > > > >
> > > > > Results :
> > > > >
> > > > > Tests in error:
> > > > >
> > > > >
> > > > >
> shouldRenderToExcelTemplate(org.openmrs.module.reporting.report.renderer.ExcelTemplateRendererTest)
>
> > > > >
> > > > >
> > > > >
> shouldRenderIndicatorsWithDifferentDatasets(org.openmrs.module.reporting.report.renderer.CohortDetailReportRendererTest)
>
> > > > >
> > > > > Tests run: 310, Failures: 0, Errors: 2, Skipped: 14
> > > > >
> > > > > ExcelTemplateRendererTest fails with a FileNotFoundException (tries
> to
> > > > > write into /tmp/test.xls).
> > > > >
> > > > > CohortDetailReportRendererTest fails also with a
> FileNotFoundException
> > > > > (tries to write into /tmp/test.html).
> > > > >
> > > > > Cheers
> > > > >
> > > > > On Fri, Dec 28, 2012 at 3:15 PM, Michael Seaton <mseaton@pih.org>
> > > > > wrote:
> > > > > > Hi Lluis,
> > > > > >
> > > > > > I'm very excited that you are preparing to take on some reporting
> > > > > > module
> > > > > > development! Please let me know how I can be of any help getting
> you
> > > > > > up
> > > > > > to
> > > > > > speed. Hopefully Darius' response has clarified what you need to
> do
> > > > > > to
> > > > > > deploy the module and see it running. Can you clarify which unit
> > > > > > tests
> > > > > > are
> > > > > > failing? I wouldn't be surprised if there are some tests that
> write
> > > > > > out
> > > > > > to
> > > > > > /tmp or another location that only exists on some systems, that
> > > > > > shouldn't do
> > > > > > so, that I was using for one thing or another. Perhaps these are
> the
> > > > > > issue?
> > > > > >
> > > > > > Thanks,
> > > > > > Mike
> > > > > >
> > > > > >
> > > > > > On 12/27/2012 05:23 PM, Lluis Martinez wrote:
> > > > > > >
> > > > > > > Hi Darius,
> > > > > > >
> > > > > > > I cloned the reporting module in Git, and configured my workarea
> > > > > > > properly (I believe). But then in the webapp the module options
> are
> > > > > > > not visible in Administration, what else do I need to do? I
> > > > > > > performed
> > > > > > > a mvn install on it and some tests failed, btw.
> > > > > > >
> > > > > > > Cheers
> > > > > > >
> > > > > > > On Sat, Dec 22, 2012 at 3:29 AM, Darius Jazayeri
> > > > > > > <djazayeri@gmail.com>
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > Hi Lluis,
> > > > > > > >
> > > > > > > > I don't know of any specific documentation about this, but it
> > > > > > > > should
> > > > > > > > work
> > > > > > > > in
> > > > > > > > a straightforward way.
> > > > > > > > All that adding extra modules does, in both eclipse and intellij,
> > > > > > > > is
> > > > > > > > make
> > > > > > > > your workspace a bit slower to index, and show you some incorrect
> > > > > > > > hits
> > > > > > > > when
> > > > > > > > you search for core openmrs classes, because the module also
> > > > > > > > includes
> > > > > > > > openmrs jars.
> > > > > > > >
> > > > > > > > -Darius (by phone)
> > > > > > > >
> > > > > > > > On Dec 21, 2012 8:11 AM, "Lluis Martinez" <lluismf@gmail.com>
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > Hi,
> > > > > > > > >
> > > > > > > > > I would like to download an existing module into my workarea
> > > > > > > > > (currently I have just openmrs core), deploy it and be able to
> > > > > > > > > debug
> > > > > > > > > it along with core. Is there any wiki explaining this, potential
> > > > > > > > > problems that could arise etc. ?
> > > > > > > > >
> > > > > > > > > Cheers
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > > > > Post: dev@openmrs.org
> > > > > > > > > Unsubscribe: dev+unsubscribe@openmrs.org
> > > > > > > > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > > > > > > > >
> > > > > > > > >
> > > > > > > > --
> > > > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > > > Post: dev@openmrs.org
> > > > > > > > Unsubscribe: dev+unsubscribe@openmrs.org
> > > > > > > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > > > > > > >
> > > > > > > >
> > > > > >
> > > > > > --
> > > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > > Post: dev@openmrs.org
> > > > > > Unsubscribe: dev+unsubscribe@openmrs.org
> > > > > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > > > > >
> > > > > >
> > > > >
> > > > > --
> > > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > > Post: dev@openmrs.org
> > > > > Unsubscribe: dev+unsubscribe@openmrs.org
> > > > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > > > >
> > > > >
> > > >
> > > > --
> > > > OpenMRS Developers: http://go.openmrs.org/dev
> > > > Post: dev@openmrs.org
> > > > Unsubscribe: dev+unsubscribe@openmrs.org
> > > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > > >
> > > >
> > >
> > > --
> > > OpenMRS Developers: http://go.openmrs.org/dev
> > > Post: dev@openmrs.org
> > > Unsubscribe: dev+unsubscribe@openmrs.org
> > > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> > >
> > >
> >
> > --
> > OpenMRS Developers: http://go.openmrs.org/dev
> > Post: dev@openmrs.org
> > Unsubscribe: dev+unsubscribe@openmrs.org
> > Manage your OpenMRS subscriptions at https://id.openmrs.org/
> >
> >
>
> --
> OpenMRS Developers: http://go.openmrs.org/dev
> Post: dev@openmrs.org
> Unsubscribe: dev+unsubscribe@openmrs.org
> Manage your OpenMRS subscriptions at https://id.openmrs.org/
>
>
>
--
OpenMRS Developers: http://go.openmrs.org/dev
Post: dev@openmrs.org
Unsubscribe: dev+unsubscribe@openmrs.org
Manage your OpenMRS subscriptions at https://id.openmrs.org/
[Attachment #3 (text/html)]
<div dir="ltr">Ha! Done. Thanks Lluis!</div><div class="gmail_extra"><br \
clear="all"><div><br>-Rafał</div> <br><br><div class="gmail_quote">On 31 December \
2012 15:49, Lluis Martinez <span dir="ltr"><<a href="mailto:lluismf@gmail.com" \
target="_blank">lluismf@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
Not yet, but will do if you put REPORT-460 in Ready to work status :-)<br>
<br>
Cheers<br>
<div class="HOEnZb"><div class="h5"><br>
On Sun, Dec 30, 2012 at 6:03 PM, Rafal Korytkowski <<a \
href="mailto:rafal@openmrs.org">rafal@openmrs.org</a>> wrote:<br> > Lluis, did \
you send a pull request with your fixed tests? :-)<br> ><br>
><br>
> -Rafał<br>
><br>
><br>
> On 28 December 2012 20:59, Lluis Martinez <<a \
href="mailto:lluismf@gmail.com">lluismf@gmail.com</a>> wrote:<br> >><br>
>> Hi Darius,<br>
>><br>
>> I corrected the failing unit tests and the omod file was generated<br>
>> after executing mvn install.<br>
>><br>
>> Thanks!<br>
>><br>
>> On Fri, Dec 28, 2012 at 7:09 PM, Darius Jazayeri <<a \
href="mailto:darius@openmrs.org">darius@openmrs.org</a>><br> >> wrote:<br>
>> > Hi Lluis,<br>
>> ><br>
>> > I'm not 100% sure of this, but I believe that the \
maven-openmrs-plugin,<br> >> > in<br>
>> > its package-module goal (see omod/pom.xml, or see its source here) \
is<br> >> > what<br>
>> > generates the omod whenever you do a mvn package or mvn install on \
the<br> >> > module's maven project.<br>
>> ><br>
>> > Effectively an omod is just a jar file with a different file \
extension,<br> >> > and<br>
>> > some extra assumptions about its directory structure.<br>
>> ><br>
>> > -Darius<br>
>> ><br>
>> ><br>
>> > On Fri, Dec 28, 2012 at 9:40 AM, Lluis Martinez <<a \
href="mailto:lluismf@gmail.com">lluismf@gmail.com</a>><br> >> > \
wrote:<br> >> >><br>
>> >> Hi Michael,<br>
>> >><br>
>> >> These are the failing unit tests:<br>
>> >><br>
>> >> Results :<br>
>> >><br>
>> >> Tests in error:<br>
>> >><br>
>> >><br>
>> >> shouldRenderToExcelTemplate(org.openmrs.module.reporting.report.renderer.ExcelTemplateRendererTest)<br>
>> >><br>
>> >><br>
>> >> shouldRenderIndicatorsWithDifferentDatasets(org.openmrs.module.reporting.report.renderer.CohortDetailReportRendererTest)<br>
>> >><br>
>> >> Tests run: 310, Failures: 0, Errors: 2, Skipped: 14<br>
>> >><br>
>> >> ExcelTemplateRendererTest fails with a FileNotFoundException (tries \
to<br> >> >> write into /tmp/test.xls).<br>
>> >><br>
>> >> CohortDetailReportRendererTest fails also with a \
FileNotFoundException<br> >> >> (tries to write into /tmp/test.html).<br>
>> >><br>
>> >> Cheers<br>
>> >><br>
>> >> On Fri, Dec 28, 2012 at 3:15 PM, Michael Seaton <<a \
href="mailto:mseaton@pih.org">mseaton@pih.org</a>><br> >> >> \
wrote:<br> >> >> > Hi Lluis,<br>
>> >> ><br>
>> >> > I'm very excited that you are preparing to take on some \
reporting<br> >> >> > module<br>
>> >> > development! Please let me know how I can be of any help \
getting you<br> >> >> > up<br>
>> >> > to<br>
>> >> > speed. Hopefully Darius' response has clarified what you \
need to do<br> >> >> > to<br>
>> >> > deploy the module and see it running. Can you clarify which \
unit<br> >> >> > tests<br>
>> >> > are<br>
>> >> > failing? I wouldn't be surprised if there are some tests \
that write<br> >> >> > out<br>
>> >> > to<br>
>> >> > /tmp or another location that only exists on some systems, \
that<br> >> >> > shouldn't do<br>
>> >> > so, that I was using for one thing or another. Perhaps these \
are the<br> >> >> > issue?<br>
>> >> ><br>
>> >> > Thanks,<br>
>> >> > Mike<br>
>> >> ><br>
>> >> ><br>
>> >> > On 12/27/2012 05:23 PM, Lluis Martinez wrote:<br>
>> >> >><br>
>> >> >> Hi Darius,<br>
>> >> >><br>
>> >> >> I cloned the reporting module in Git, and configured my \
workarea<br> >> >> >> properly (I believe). But then in the webapp \
the module options are<br> >> >> >> not visible in Administration, \
what else do I need to do? I<br> >> >> >> performed<br>
>> >> >> a mvn install on it and some tests failed, btw.<br>
>> >> >><br>
>> >> >> Cheers<br>
>> >> >><br>
>> >> >> On Sat, Dec 22, 2012 at 3:29 AM, Darius Jazayeri<br>
>> >> >> <<a \
href="mailto:djazayeri@gmail.com">djazayeri@gmail.com</a>><br> >> >> \
>> wrote:<br> >> >> >>><br>
>> >> >>> Hi Lluis,<br>
>> >> >>><br>
>> >> >>> I don't know of any specific documentation about \
this, but it<br> >> >> >>> should<br>
>> >> >>> work<br>
>> >> >>> in<br>
>> >> >>> a straightforward way.<br>
>> >> >>> All that adding extra modules does, in both eclipse \
and intellij,<br> >> >> >>> is<br>
>> >> >>> make<br>
>> >> >>> your workspace a bit slower to index, and show you \
some incorrect<br> >> >> >>> hits<br>
>> >> >>> when<br>
>> >> >>> you search for core openmrs classes, because the \
module also<br> >> >> >>> includes<br>
>> >> >>> openmrs jars.<br>
>> >> >>><br>
>> >> >>> -Darius (by phone)<br>
>> >> >>><br>
>> >> >>> On Dec 21, 2012 8:11 AM, "Lluis Martinez" \
<<a href="mailto:lluismf@gmail.com">lluismf@gmail.com</a>><br> >> \
>> >>> wrote:<br> >> >> >>>><br>
>> >> >>>> Hi,<br>
>> >> >>>><br>
>> >> >>>> I would like to download an existing module into \
my workarea<br> >> >> >>>> (currently I have just openmrs \
core), deploy it and be able to<br> >> >> >>>> debug<br>
>> >> >>>> it along with core. Is there any wiki explaining \
this, potential<br> >> >> >>>> problems that could arise etc. \
?<br> >> >> >>>><br>
>> >> >>>> Cheers<br>
>> >> >>>><br>
>> >> >>>> --<br>
>> >> >>>> OpenMRS Developers: <a \
href="http://go.openmrs.org/dev" target="_blank">http://go.openmrs.org/dev</a><br> \
>> >> >>>> Post: <a \
href="mailto:dev@openmrs.org">dev@openmrs.org</a><br> >> >> \
>>>> Unsubscribe: <a \
href="mailto:dev%2Bunsubscribe@openmrs.org">dev+unsubscribe@openmrs.org</a><br> \
>> >> >>>> Manage your OpenMRS subscriptions at <a \
href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br> \
>> >> >>>><br> >> >> >>>><br>
>> >> >>> --<br>
>> >> >>> OpenMRS Developers: <a \
href="http://go.openmrs.org/dev" target="_blank">http://go.openmrs.org/dev</a><br> \
>> >> >>> Post: <a \
href="mailto:dev@openmrs.org">dev@openmrs.org</a><br> >> >> >>> \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org">dev+unsubscribe@openmrs.org</a><br>
>> >> >>> Manage your OpenMRS subscriptions at <a \
href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br> \
>> >> >>><br> >> >> >>><br>
>> >> ><br>
>> >> > --<br>
>> >> > OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
target="_blank">http://go.openmrs.org/dev</a><br> >> >> > Post: <a \
href="mailto:dev@openmrs.org">dev@openmrs.org</a><br> >> >> > \
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org">dev+unsubscribe@openmrs.org</a><br>
>> >> > Manage your OpenMRS subscriptions at <a \
href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br> \
>> >> ><br> >> >> ><br>
>> >><br>
>> >> --<br>
>> >> OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
target="_blank">http://go.openmrs.org/dev</a><br> >> >> Post: <a \
href="mailto:dev@openmrs.org">dev@openmrs.org</a><br> >> >> Unsubscribe: \
<a href="mailto:dev%2Bunsubscribe@openmrs.org">dev+unsubscribe@openmrs.org</a><br> \
>> >> Manage your OpenMRS subscriptions at <a \
href="https://id.openmrs.org/" target="_blank">https://id.openmrs.org/</a><br> \
>> >><br> >> >><br>
>> ><br>
>> > --<br>
>> > OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
target="_blank">http://go.openmrs.org/dev</a><br> >> > Post: <a \
href="mailto:dev@openmrs.org">dev@openmrs.org</a><br> >> > Unsubscribe: <a \
href="mailto:dev%2Bunsubscribe@openmrs.org">dev+unsubscribe@openmrs.org</a><br> \
>> > Manage your OpenMRS subscriptions at <a href="https://id.openmrs.org/" \
target="_blank">https://id.openmrs.org/</a><br> >> ><br>
>> ><br>
>><br>
>> --<br>
>> OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
target="_blank">http://go.openmrs.org/dev</a><br> >> Post: <a \
href="mailto:dev@openmrs.org">dev@openmrs.org</a><br> >> Unsubscribe: <a \
href="mailto:dev%2Bunsubscribe@openmrs.org">dev+unsubscribe@openmrs.org</a><br> \
>> Manage your OpenMRS subscriptions at <a href="https://id.openmrs.org/" \
target="_blank">https://id.openmrs.org/</a><br> >><br>
>><br>
><br>
> --<br>
> OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
target="_blank">http://go.openmrs.org/dev</a><br> > Post: <a \
href="mailto:dev@openmrs.org">dev@openmrs.org</a><br> > Unsubscribe: <a \
href="mailto:dev%2Bunsubscribe@openmrs.org">dev+unsubscribe@openmrs.org</a><br> > \
Manage your OpenMRS subscriptions at <a href="https://id.openmrs.org/" \
target="_blank">https://id.openmrs.org/</a><br> ><br>
><br>
<br>
--<br>
OpenMRS Developers: <a href="http://go.openmrs.org/dev" \
target="_blank">http://go.openmrs.org/dev</a><br>
Post: <a href="mailto:dev@openmrs.org">dev@openmrs.org</a><br>
Unsubscribe: <a href="mailto:dev%2Bunsubscribe@openmrs.org">dev+unsubscribe@openmrs.org</a><br>
Manage your OpenMRS subscriptions at <a href="https://id.openmrs.org/" \
target="_blank">https://id.openmrs.org/</a><br> <br>
<br>
</div></div></blockquote></div><br></div>
<p></p>
-- <br />
OpenMRS Developers: <a \
href="http://go.openmrs.org/dev">http://go.openmrs.org/dev</a><br />
Post: dev@openmrs.org<br />
Unsubscribe: dev+unsubscribe@openmrs.org<br />
Manage your OpenMRS subscriptions at <a \
href="https://id.openmrs.org/">https://id.openmrs.org/</a><br /> <br />
<br />
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic