[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openmosix-devel
Subject:    Re: [Openmosix-devel] patch to fix process name: omkmigd ->
From:       "Matt Dew" <Matt.Dew () seakr ! com>
Date:       2006-04-27 18:02:47
Message-ID: 4450B2E7020000B500003F53 () collaborate ! seakr ! com
[Download RAW message or body]

Hi Tab,
Here's the updated patch.  Tabs instead of spaces and I put in sizeof(m->comm) \
instead of sizeof(char)*TASK_COMM_LEN.  I see lots of your way in the kernel code and \
I'm all for consistency.

Matt

> > > Vincent Hanquez <tab@snarc.org>  >>>
On Thu, Apr 27, 2006 at 08:19:16AM -0600, Matt Dew wrote:
> (I forgot to send this to the list yesterday.)
 (duh just when I reply to your private email ;))

> After your comments on proc Tab, I did some thinking and I believe
> that was the wrong way to do things.

agreed

> The process name should come across from the home node.   Here's a
> patch that adds the comm field to the omp_mig_task struct and updates
> the remote node as it does uid,gid, etc.  A much cleaner and safer way
> to do the same thing. Also less code. 
> 
> This patch must be applied to all nodes at the same time, due to the
> struct difference.

The patch looks good, except it's still using spaces to indent instead
of tab.

Please resend with correct indentation that I can git-apply it.

minor nit:
You can use sizeof(m->comm) instead of sizeof(char) * TASK_COMM_LEN

Cheers,
-- 
Vincent Hanquez


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
openMosix-devel mailing list
openMosix-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openmosix-devel


["patch-2.6.16-20060427" (application/octet-stream)]
-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
openMosix-devel mailing list
openMosix-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openmosix-devel

[prev in list] [next in list] [prev in thread] [next in thread]