[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openmoko-shr-devel
Subject:    [Shr-devel] [PATCH 2/2] Don't strdup the keys in the row properties
From:       tilman () code-monkey ! de (Tilman Sauerbeck)
Date:       2009-01-18 20:57:34
Message-ID: 1232312254-7540-2-git-send-email-tilman () code-monkey ! de
[Download RAW message or body]

They are in read-only memory anyway, so we don't need to pass in copies.
Compile tested only.
---
 .../src/widget/elm_my_contactlist.c                |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/libframeworkd-phonegui-efl/src/widget/elm_my_contactlist.c \
b/libframeworkd-phonegui-efl/src/widget/elm_my_contactlist.c index 975a99f..b291049 \
                100644
--- a/libframeworkd-phonegui-efl/src/widget/elm_my_contactlist.c
+++ b/libframeworkd-phonegui-efl/src/widget/elm_my_contactlist.c
@@ -107,9 +107,12 @@ _process_entry(GValueArray *entry, void *data) {
     Widget_Data *wd = elm_widget_data_get(data);
 
     GHashTable *parameters = g_hash_table_new(g_str_hash, g_str_equal);
-    g_hash_table_insert(parameters, strdup("id"), \
                g_value_get_int(g_value_array_get_nth(entry, 0)));
-    g_hash_table_insert(parameters, strdup("name"), \
                strdup(g_value_get_string(g_value_array_get_nth(entry, 1))));
-    g_hash_table_insert(parameters, strdup("number"), \
strdup(g_value_get_string(g_value_array_get_nth(entry, 2)))); +
+    /* FIXME: We'll leak those strdup'd strings below. */
+    g_hash_table_insert(parameters, (gpointer) "id", \
g_value_get_int(g_value_array_get_nth(entry, 0))); +    \
g_hash_table_insert(parameters, (gpointer) "name", \
strdup(g_value_get_string(g_value_array_get_nth(entry, 1)))); +    \
g_hash_table_insert(parameters, (gpointer) "number", \
strdup(g_value_get_string(g_value_array_get_nth(entry, 2)))); +
     Etk_Tree_Row *row = etk_tree_row_append(ETK_TREE(wd->tree), NULL, wd->col1, \
parameters, NULL);  
     etk_tree_row_data_set_full(row, parameters, _row_delete_callback);
-- 
1.6.1


[prev in list] [next in list] [prev in thread] [next in thread]