[prev in list] [next in list] [prev in thread] [next in thread]
List: openmoko-distro-devel
Subject: Re: [PATCH] main: Print interface information after it has been
From: Stefan Schmidt <stefan () datenfreihafen ! org>
Date: 2011-05-24 9:44:16
Message-ID: 20110524094416.GA7283 () excalibur ! local
[Download RAW message or body]
Hello.
On Tue, 2011-05-24 at 11:05, Tormod Volden wrote:
> On Mon, May 23, 2011 at 8:17 PM, Stefan Schmidt wrote:
> > > Sadly a problem on the freerunner persists in the libusb-1.0 branch
> > > even with this patch applied. Trying to donwload something just dies
> > > without segfault and leaves the following in dmesg:
> > >
> > > [1285088.771326] dfu-util[18547] general protection ip:4027f6 sp:7fffc6d2a610 \
> > > error:0 in dfu-util[400000+6000]
> > > I know you don't have an freerunner so I will try to chase this down
> > > the next days. Its the last blocker for getting the libusb-1.0 branch
> > > merged into master.
> >
> > I spent some time on this at the weekend. It actually did work before
> > in the libusb-1.0 branch. Your commit that fixed your device broke it
> > for the freerunner:
> >
> > commit 6329fc0886049e0eb50c51e88b7fc52f056b83d4
> > Author: Tormod Volden <debian.tormod@gmail.com>
> > Date: Thu Feb 3 23:12:35 2011 +0100
> >
> > main: Use the config descriptor value, not the index
> >
> > Its libusb_get_config_descriptor_by_value() in print_dfu_if thats
> > failing and thus the cfg being not populated. As you observed
> > yourself.
>
> Yes, libusb_get_config_descriptor_by_value() was failing because it is
> called with dfu_if->configuration and dfu_if was not fully populated
> so the "configuration" member was wrong. Before my commit "Use the
> config descriptor value, not the index" this happened to work anyway
> because the uninitialized value (zero) in most cases was correct
> (index 0, the first one). On the other hand, the correct /value/ is
> most of the times 1, so passing 0 will fail. This was fixed by the
> patch in this thread. You still haven't applied it to the libusb-1.0
> branch though. I hope you are always merging in master before you
> build from libusb-1.0?
It was in the branch already I just forgot to push it out. Sorry for
that. Normally I cherry-pick single commits.
regards
Stefan Schmidt
_______________________________________________
devel mailing list
devel@lists.openmoko.org
https://lists.openmoko.org/mailman/listinfo/devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic