[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openldap-devel
Subject:    Re: mm_last_pg+1 != filesize
From:       Hallvard Breien Furuseth <h.b.furuseth () usit ! uio ! no>
Date:       2016-01-05 22:39:50
Message-ID: 568C4636.1050408 () usit ! uio ! no
[Download RAW message or body]

I forgot this thread...

On 22/12/15 16:39, Howard Chu wrote:
>> Not malicious.  Omit some commits like slapadd -q does, and it can happen
>> naturally.  Maybe slapadd -q can do just that with large IDLs.
>
> The change in question was for msync, which is only used for
> MDB_WRITEMAP.

True, I missed that.

> Regular fdatasync doesn't require a length parameter, so it's irrelevant.
>
>> I think MDB_meta and MDB_txn need "last written page" maintained
>> by mdb_page_flush().  Can VL32 wait for MDB_DATA_VERSION > 1?
>
> mdb_page_flush() already maintains last_pgno for MDB_VL32.

Yes, but it initializes mt_last_pgno = meta->mm_last_pg, which
can be beyond the filesize.

I mean to get back to that test program and test it on Windows with
bigger memory chunks, but I don't seem to be getting around to it...

[prev in list] [next in list] [prev in thread] [next in thread]