[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openldap-devel
Subject:    Re: commit: ldap/servers/slapd syncrepl.c
From:       masarati () aero ! polimi ! it
Date:       2010-04-19 19:49:16
Message-ID: 3a2a491c77f02e42abc64073d4f06149.squirrel () www ! aero ! polimi ! it
[Download RAW message or body]


>> Two comments:
>>
>> 1) syncrepl_add_glue() and syncrepl_add_glue_ancestors() should be
>> renamed
>> slapd_add_glue() and slapd_add_glue_ancestors(); the latter should be
>> exposed as well, as it may be useful to other modules.
>>
>> 2) syncrepl_add_glue_ancestors() returning alreadyExists when the
>> immediate parent entry exists is pointless, as it does not indicate an
>> error, while the existence of a non-immediate ancestor would not be
>> notified to the caller.  BTW, this caused ITS#6528 (my fault, of
>> course).
>
>
> Are you planning on doing #1 & #2 prior to 2.4.22?  Or are they ok for now
> as well?

No. 2.4.22 should be fine as it is now.  Thanks, p.

[prev in list] [next in list] [prev in thread] [next in thread]