[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openldap-devel
Subject:    Re: commit: ldap/servers/slapd syncrepl.c
From:       Howard Chu <hyc () symas ! com>
Date:       2008-12-29 14:40:00
Message-ID: 4958E140.4030702 () symas ! com
[Download RAW message or body]

Rein Tollevik wrote:
> hyc@OpenLDAP.org wrote:
>> Update of /repo/OpenLDAP/pkg/ldap/servers/slapd
>>
>> Modified Files:
>> 	syncrepl.c  1.434 ->  1.435
>>
>> Log Message:
>> ITS#5866 skip CSN check for glue entries
>>
>>
>> CVS Web URLs:
>>    http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/
>>      http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/syncrepl.c
>
> This patch adds test for "!is_entry_glue( rs->sr_entry )" twice, both in
> the outer and the inner if condition.  A suspect it should only have
> been in the inner condition?

Ah right, thanks for catching that. Fixed now in HEAD. Was testing a couple 
different approaches at first and didn't fully cleanup before...

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/
[prev in list] [next in list] [prev in thread] [next in thread]