[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-zero-dev
Subject:    pd_InlineSmallCode ?
From:       gbenson () redhat ! com (Gary Benson)
Date:       2010-08-09 8:30:32
Message-ID: 20100809083032.GA3337 () redhat ! com
[Download RAW message or body]

Rob Savoye wrote:
> I have the beginnings of a patch to fix the ARM calling convention at:
> http://www.senecass.com/projects/OpenJDK-ARM/thumb2-call.patch
> 
> All this patch does is add an THREAD_LAST_JAVA_FP offset to
> the defines in asm_helper.cpp, and then use that instead of
> THREAD_LAST_JAVA_SP.  This seems too simple a change, so I'm
> gonna assume it's not complete. :-)

No, it's not.

Firstly, you only need to change THREAD_LAST_JAVA_SP to
THREAD_LAST_JAVA_FP when the value you are setting it to
is zero.

Secondly, when the value is not zero, THREAD_LAST_JAVA_SP
needs setting to the top of the Zero stack, and you need
to order the writes such that THREAD_LAST_JAVA_FP is valid
whenever THREAD_LAST_JAVA_SP is not zero.  Basically it
must match JavaFrameAnchor::set (in javaFrameAnchor_zero.hpp).

Cheers,
Gary

--
http://gbenson.net/

[prev in list] [next in list] [prev in thread] [next in thread]