[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-xrender-dev
Subject:    X11GraphicsDevice.makeConfigurations()
From:       linuxhippy () gmail ! com (Clemens Eisserer)
Date:       2008-11-29 18:23:22
Message-ID: 194f62550811291023h59ea3aa2yd2cb8649c628f0f3 () mail ! gmail ! com
[Download RAW message or body]

Hi Mark,

Thanks for reading through the code.
Yes seems I mixed that up.

Thanks again,  Clemens

2008/11/28 Mark Wielaard <mark at klomp.org>:
> Hi,
>
> I was reading the code and saw that
> X11GraphicsDevice.makeConfigurations() has:
>
>      boolean xrender = X11GraphicsEnvironment.isXRenderAvailable();
>
>      if(!xrender)
>      {
>          ret[i] = XRGraphicsConfig.getConfig(this, visNum, depth,
>                            getConfigColormap(i, screen),
>                            doubleBuffer);
>      }else
>      {
>          ret[i] = X11GraphicsConfig.getConfig(this, visNum, depth,
>                   getConfigColormap(i, screen),
>                   doubleBuffer);
>      }
>
> Isn't this backwards?
>
> makeDefaultConfiguration() has it as follows:
>
>      if(X11GraphicsEnvironment.isXRenderAvailable())
>      {
>              System.out.println("XRender pipeline enabled");
>          defaultConfig = XRGraphicsConfig.getConfig(this, visNum,
>                  depth, getConfigColormap(0, screen),
>                  doubleBuffer);
>       }else
>       {
>          defaultConfig = X11GraphicsConfig.getConfig(this, visNum,
>                  depth, getConfigColormap(0, screen),
>                  doubleBuffer);
>       }
>
> Cheers,
>
> Mark
>
>


[prev in list] [next in list] [prev in thread] [next in thread]