[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-type-annotations-dev
Subject:    Re: bug in attribution of annotations in anonymous classes
From:       Werner Dietl <wdietl () gmail ! com>
Date:       2013-02-12 1:11:03
Message-ID: CAJYRO=4+t_kN5o5ufm9K7yrM23MR3bw_R=dLMOisyK4WPd8W9Q () mail ! gmail ! com
[Download RAW message or body]

Hi Steve,

are these webrevs going into TL in time for the M7 freeze?

cu, WMD.

On Mon, Feb 11, 2013 at 8:11 AM, Steve Sides <steve.sides@oracle.com> wrote:
> Hi Werner,
>
> This was a while ago. :)
>
> I believe this case has been resolved. The tests were amended for this and
> some other issues.
> I posted a patch (http://cr.openjdk.java.net/~ssides/8007339/) which allows
> the target tests to run and pass.
> It has webrev comments describing those changes. The first test now runs all
> test case and the second skips a few failing cases.
> I also posted a test for new,cast and array
> levels(http://cr.openjdk.java.net/~ssides/8005681/).
>
> -steve
>
>
>
> On 2/9/2013 6:48 PM, Werner Dietl wrote:
>>
>> Hi Steve,
>>
>>>>> First, that test case I attaIched looks a little suspicious.  It may
>>>>> not
>>>>>
>>>>> be
>>>>> expected the correct counts.
>>>>> However, I do still see extra annotations on anonymous classes.
>>>>> I'll have to give that test a better look.
>>>>
>>>> Sorry, I haven't gotten to look at anonymous classes yet.
>>>
>>> Good. Gives me more time to fix that test.
>>
>> I just looked at this issue and can (no longer?) reproduce it.
>> Please push your test case for this and let me know whether it works
>> as expected or not.
>>
>>
>>>>> Second, should type-annotations in lambda expressions be working?
>>>>> I do not see any written to the classfile.
>>>>
>>>> I don't expect anything related to type annotations and lambda to
>>>> currently work. I've added very basic support, but the EG is still
>>>> discussing the final storage format.
>>>
>>> Yep.  Currently, I can put them there, and it all compiles, but they are
>>> otherwise ignored.
>>
>> Type annotations for method and constructor references and their type
>> arguments are implemented. It would be great if you could expand on
>> the tests in
>>
>> tools/javac/annotations/typeAnnotations/referenceinfos/Lambda.java
>>
>> Type annotations in lambda expressions are still to be implemented -
>> see the discussion in an earlier mail today.
>>
>> Thanks,
>> cu, WMD.
>>
>



-- 
http://www.google.com/profiles/wdietl
[prev in list] [next in list] [prev in thread] [next in thread]