[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-swing-dev
Subject:    Re: RFR: 8332416: Add more font selection options to Font2DTest [v2]
From:       Phil Race <prr () openjdk ! org>
Date:       2024-05-16 23:42:02
Message-ID: bR6ol7TtnPZEr4EbEFnOp-1Q0Ny7FryeeFYX_WgqqFg=.5f6e4eb0-1b5a-48d2-99c8-8941db993766 () github ! com
[Download RAW message or body]

On Thu, 16 May 2024 19:16:26 GMT, Phil Race <prr@openjdk.org> wrote:

> > Enhance Font2DTest as follows
> > 
> > - Add main menu Radio Button options so that you select the font to use as either
> > - (1) Font Family  + Style (as now)
> > - (2) Font Family + Menu of all members of the Family, replacing the Style
> > - (3) List of all fontnames - which can still be adjusted by Style if you want.
> > The default is (1) so nothing looks different except that I updated the UI to use \
> > Nimbus instead of Metal. 
> > There's new code to gather these ways of referencing the fonts.
> > Also changes were needed for the "Save/Load" options to include the new UI state \
> > and font settings.
> 
> Phil Race has updated the pull request incrementally with one additional commit \
> since the last revision: 
> 8332416

BTW, it is probably obvious , but maybe 50% of "reviewing" this will be pulling it \
down and building it locally and trying it out. Very hard to review by code changes \
alone.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19273#issuecomment-2116378508


[prev in list] [next in list] [prev in thread] [next in thread]