[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-swing-dev
Subject: Re: <Swing Dev> <AWT Dev> [15] RFR : 8249278 : Revert JDK-8226253 which breaks the spec of Accessibl
From: Philip Race <philip.race () oracle ! com>
Date: 2020-07-15 15:43:55
Message-ID: 5F0F243B.6050607 () oracle ! com
[Download RAW message or body]
+1
-phil
On 7/14/20, 7:44 PM, Ambarish Rapte wrote:
>
> Hello Phil,
>
> Thanks for the review and correcting the mail group,
>
> Please take a look at the updated webrev with © years also backed out:
>
> http://cr.openjdk.java.net/~arapte/a11y/8249278/webrev.1
> <http://cr.openjdk.java.net/%7Earapte/a11y/8249278/webrev.1>
>
> Regards,
>
> Ambarish.
>
> *From:*Philip Race
> *Sent:* Wednesday, July 15, 2020 2:00 AM
> *To:* Ambarish Rapte <ambarish.rapte@oracle.com>;
> swing-dev@openjdk.java.net
> *Cc:* awt-dev@openjdk.java.net
> *Subject:* Re: <AWT Dev> [15] RFR : 8249278 : Revert JDK-8226253
>
> adding swing-dev which is the correct list for this Swing change.
>
> It looks like a faithful backout of
> https://bugs.openjdk.java.net/browse/JDK-8226253
> https://hg.openjdk.java.net/jdk/jdk/rev/3ea8a0c5c264
>
> except that the (c) year is remaining 2020 .. which I think just
> indicates the silliness of all these (c) updates since the only
> changes to these files in 2020 were those which you have now backed out.
>
> So I think you should revert the (c) changes as well.
>
> If some one else comes along and updates all files in JDK with updates
> in 2020
> and so re-adds it then that is their problem ...
>
> -phil.
>
> On 7/14/20, 5:37 AM, Ambarish Rapte wrote:
>
> Hi,
>
> Please review this fix:
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8249278
>
> Webrev: http://cr.openjdk.java.net/~arapte/a11y/8249278/webrev.0/
> <http://cr.openjdk.java.net/%7Earapte/a11y/8249278/webrev.0/>
>
> This change reverts the fix for JDK-8226253.
>
> The fix of JDK-8226253 breaks the specification of
> AccessibleState.SHOWING for JList and has caused a regression with
> JTree.
>
> There is no alternative to fix JDK-8226253 on JDK side and the
> issue should be really fixed on Screen reader side.
>
> So in order to keep the correctness of spec and avoid any new
> regression, the fix needs to be reverted.
>
> Regards,
>
> Ambarish
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
+1<br>
<br>
-phil<br>
<br>
On 7/14/20, 7:44 PM, Ambarish Rapte wrote:
<blockquote cite="mid:e80ceb5d-2c46-4e88-82dc-5ef3ca91eaed@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:windowtext">Hello \
Phil,<o:p></o:p></span></p>
<p class="MsoNormal"><span \
style="color:windowtext"><o:p> </o:p></span></p> <p class="MsoNormal"><span \
style="color:windowtext">Thanks for
the review and correcting the mail group,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:windowtext">Please take
a look at the updated webrev with © years also backed out: \
<o:p></o:p></span></p> <p class="MsoNormal"><span style="color:windowtext"><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Earapte/a11y/8249278/webrev.1">http://cr.openjdk.java.net/~arapte/a11y/8249278/webrev.1</a><o:p></o:p></span></p>
<p class="MsoNormal"><span \
style="color:windowtext"><o:p> </o:p></span></p>
<p class="MsoNormal"><span \
style="color:windowtext">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span \
style="color:windowtext">Ambarish.<o:p></o:p></span></p> <div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span \
style="color:windowtext">From:</span></b><span style="color:windowtext"> Philip Race \
<br> <b>Sent:</b> Wednesday, July 15, 2020 2:00 AM<br>
<b>To:</b> Ambarish Rapte
<a class="moz-txt-link-rfc2396E" \
href="mailto:ambarish.rapte@oracle.com"><ambarish.rapte@oracle.com></a>;
<a class="moz-txt-link-abbreviated" \
href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><br>
<b>Cc:</b> <a class="moz-txt-link-abbreviated" \
href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br> \
<b>Subject:</b> Re: <AWT Dev> [15] RFR : 8249278 : Revert \
JDK-8226253<o:p></o:p></span></p> </div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">adding swing-dev which is the correct list
for this Swing change.<br>
<br>
It looks like a faithful backout of<br>
<a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8226253">https://bugs.openjdk.java.net/browse/JDK-8226253</a><br>
<a moz-do-not-send="true"
href="https://hg.openjdk.java.net/jdk/jdk/rev/3ea8a0c5c264">https://hg.openjdk.java.net/jdk/jdk/rev/3ea8a0c5c264</a><br>
<br>
except that the (c) year is remaining 2020 .. which I think
just<br>
indicates the silliness of all these (c) updates since the
only<br>
changes to these files in 2020 were those which you have now
backed out.<br>
<br>
So I think you should revert the (c) changes as well.<br>
<br>
If some one else comes along and updates all files in JDK with
updates in 2020<br>
and so re-adds it then that is their problem ...<br>
<br>
-phil.<br>
<br>
On 7/14/20, 5:37 AM, Ambarish Rapte wrote: <o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Please review this fix: <o:p></o:p></p>
<p class="MsoNormal">JBS: <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8249278">https://bugs.openjdk.java.net/browse/JDK-8249278</a><o:p></o:p></p>
<p class="MsoNormal">Webrev: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Earapte/a11y/8249278/webrev.0/">http://cr.openjdk.java.net/~arapte/a11y/8249278/webrev.0/</a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">This change reverts the fix for
JDK-8226253.<o:p></o:p></p>
<p class="MsoNormal">The fix of JDK-8226253 breaks the
specification of AccessibleState.SHOWING for JList and has
caused a regression with JTree.<o:p></o:p></p>
<p class="MsoNormal">There is no alternative to fix
JDK-8226253 on JDK side and the issue should be really fixed
on Screen reader side.<o:p></o:p></p>
<p class="MsoNormal">So in order to keep the correctness of
spec and avoid any new regression, the fix needs to be
reverted.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Regards,<o:p></o:p></p>
<p class="MsoNormal">Ambarish<o:p></o:p></p>
</blockquote>
</div>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic