[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-swing-dev
Subject:    <Swing Dev> [9] Review request for 8075084: https://bugs.openjdk.java.net/browse/JDK-8075084
From:       Semyon Sadetsky <semyon.sadetsky () oracle ! com>
Date:       2016-10-25 13:24:10
Message-ID: bdab011c-6107-887c-3c89-9cfe3586208c () oracle ! com
[Download RAW message or body]

Hello,

Please review fix for JDK9:

bug: https://bugs.openjdk.java.net/browse/JDK-8075084

webrev: http://cr.openjdk.java.net/~ssadetsky/8075084/webrev.00/

When a modal dialog is shown in scroll bar button click listener it 
blocks all events targeted to the scroll bar owner window.

At the same time clicking on scroll bar button triggers a timer which 
should adjust scroll bar value automatically until mouse button is 
released, i.e. until mouse release event comes to the pushed scroll 
button. So, this timer is not stopped by the mouse release event because 
it is rejected by the modal filter.  When modal dialog is closed the 
timer continues to produce scroll adjustment events and the dialog is 
shown again. Also the scroll button remains pushed and hovered all the 
time (because it didn't get mouse release event).

In the suggested fix the timer is started only if the scroll bar owner 
window keeps input focus after the adjustment callback and the scroll 
button is reset otherwise.

--Semyon

[prev in list] [next in list] [prev in thread] [next in thread]