[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-swing-dev
Subject:    Re: <Swing Dev> [9] Review request for 8164321: Crash of SwingNode with GTK LaF
From:       Alexandr Scherbatiy <alexandr.scherbatiy () oracle ! com>
Date:       2016-10-14 17:49:07
Message-ID: 12df2281-3ad2-2f74-bfb0-7ffff55685be () oracle ! com
[Download RAW message or body]


The fix looks good to me.

Thanks,
Alexandr.

On 10/11/2016 8:56 PM, Alexander Zvegintsev wrote:
> +1
>
>
> On 10/6/16 11:18 AM, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK9:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8164321
>>
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8164321/webrev.00/
>>
>> The issue is caused by concurrent XLib access form FX and AWT toolkit 
>> threads in case of GTK3. To fix the issue wrapping by 
>> gdk_threads_enter/gdk_threads_leave is added to JDK GTK+ LnF GTK3 
>> implementation. Since FX GTK3 implementation uses 
>> gdk_threads_enter/gdk_threads_leave as well this will make GTK3 XLib 
>> calls serialized.
>>
>> --Semyon
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]