[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-swing-dev
Subject:    Re: <Swing Dev> Review request for JDK-8078489 JSpinner using SpinnerNumberModel doesn't honor orien
From:       Sergey Bylokhov <Sergey.Bylokhov () oracle ! com>
Date:       2015-12-24 16:08:56
Message-ID: 567C1898.7070702 () oracle ! com
[Download RAW message or body]

On 24/12/15 08:18, Rajeev Chamyal wrote:
> Hello Sergey,
> 
> Thanks for the review.
> The issues is reproducible with mac Aqua LAF only with other LAF/platforms issue is \
> not reproducible.

I am sure that this bug was reproduced on Aqua because we had not the 
test which cover this area for all supported look and feels. So when the 
new LaF was added the bug was not found. So I suggest to remove 
limitation on osx and to add the coverage for all supported LaFs, to 
prove that the same bug will not occur on some old/new LaF.

> I have updated webrev as per review comments.
> 
> http://cr.openjdk.java.net/~rchamyal/8078489/webrev.01/
> 
> Regards,
> Rajeev Chamyal
> 
> -----Original Message-----
> From: Sergey Bylokhov
> Sent: 23 December 2015 21:08
> To: Rajeev Chamyal; Alexander Scherbatiy; Prasanta Sadhukhan; \
>                 swing-dev@openjdk.java.net
> Subject: Re: Review request for JDK-8078489 JSpinner using SpinnerNumberModel \
> doesn't honor orientation flag 
> Hi, Rajeev.
> A few notes:
> - the cast in the "if (o != (ComponentOrientation) e.getOldValue())"
> is not necessary.
> - Is it possible to cover all look and feels in the test?
> - Why the test is for osx only?
> 
> On 22/12/15 12:54, Rajeev Chamyal wrote:
> > Hello All,
> > 
> > Please review the following fix for Jdk9:
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8078489
> > 
> > Webrev:http://cr.openjdk.java.net/~rchamyal/8078489/webrev.00/
> > 
> > Issue: Jspinner text in Aqua LAF is not following Right to left
> > component orientation.
> > 
> > Cause: Code for JSpinner Component orientation is missing.
> > 
> > Fix: Updated the property change listener of Aqua LAF to update editor
> > text orientation.
> > 
> > Regards,
> > 
> > Rajeev Chamyal
> > 
> 
> 
> --
> Best regards, Sergey.
> 


-- 
Best regards, Sergey.


[prev in list] [next in list] [prev in thread] [next in thread]