[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-swing-dev
Subject:    Re: <Swing Dev> [9] Review Request for 8145787: [TEST_BUG][PIT] javax/swing/undo/UndoManager/Abstrac
From:       Semyon Sadetsky <semyon.sadetsky () oracle ! com>
Date:       2015-12-22 16:18:50
Message-ID: 567977EA.7080903 () oracle ! com
[Download RAW message or body]

This situation is not possible because all undos are called on the same 
thread. Modifications are executed from other 2 threads can only 
increase the undo stack.

On 12/22/2015 7:07 PM, Sergey Bylokhov wrote:
> Looks like there is no any syncronisation is it possible that this 
> erroneous situation will occur after the check "canUndoOrRedo" but 
> before the "undoOrRedo"?
>
> On 22/12/15 16:47, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK9:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8145787
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8145787/webrev.00/
>>
>> This is a multithreading stress test in which the undo queue depth may
>> reach zero sometimes occasionally. The corresponding checks were added.
>>
>> --Semyon
>>
>
>

[prev in list] [next in list] [prev in thread] [next in thread]