[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-swing-dev
Subject:    Re: <Swing Dev> <AWT> [9] Review Request: JDK-8076151 Fix for Test java/awt/FontClass/CreateFont/fil
From:       Alexander Scherbatiy <alexandr.scherbatiy () oracle ! com>
Date:       2015-04-09 11:53:37
Message-ID: 55266841.602 () oracle ! com
[Download RAW message or body]


   The fix looks good to me.

   Thanks,
   Alexandr.

On 4/9/2015 2:35 PM, Alexander Zvegintsev wrote:
> still looks good to me.
>
> Thanks,
>
> Alexander.
>
> On 04/09/2015 12:03 PM, pooja chopra wrote:
>> Hi Alexander,
>> I have updated the copyright header in TestFontFile.sh. Please find 
>> the updated webrev below :-
>>
>> 8076151 [TEST_BUG] Test 
>> java/awt/FontClass/CreateFont/fileaccess/FontFile.java fails
>> Test bug fix.
>> https://bugs.openjdk.java.net/browse/JDK-8076151
>> The webrev is: http://cr.openjdk.java.net/~kshefov/8076151/webrev.02
>>
>> Regards,
>> Pooja
>> On 4/8/2015 3:57 PM, Alexander Zvegintsev wrote:
>>> Hi Pooja,
>>>
>>> Please fix the copyright header in TestFontFile.sh before the push, 
>>> it is too short(only 2 lines).
>>> Otherwise the fix looks good to me.
>>>
>>> Thanks,
>>>
>>> Alexander.
>>>
>>> On 04/08/2015 10:29 AM, pooja chopra wrote:
>>>> Hi ,
>>>>
>>>> Gentle Reminder. Please review below fix :
>>>>
>>>> 8076151 [TEST_BUG] Test 
>>>> java/awt/FontClass/CreateFont/fileaccess/FontFile.java fails
>>>> Test bug fix.
>>>> https://bugs.openjdk.java.net/browse/JDK-8076151
>>>> The webrev is: http://cr.openjdk.java.net/~kshefov/8076151/webrev.01/
>>>>
>>>> Regards,
>>>> Pooja
>>>>
>>>> On 4/1/2015 2:28 PM, Alexander Scherbatiy wrote:
>>>>>
>>>>>   The fix looks good to me.
>>>>>
>>>>>   Thanks,
>>>>>   Alexandr.
>>>>>
>>>>> On 3/31/2015 8:23 PM, pooja chopra wrote:
>>>>>> Hi Alexander,
>>>>>> I have updated the copyright year in TestFontFile.sh . Please 
>>>>>> find the updated webrev link  :-
>>>>>> the webrev is: http://cr.openjdk.java.net/~kshefov/8076151/webrev.01
>>>>>>
>>>>>> Regards,
>>>>>> Pooja
>>>>>> On 3/30/2015 9:01 PM, Alexander Scherbatiy wrote:
>>>>>>>
>>>>>>>   The fix looks good to me.
>>>>>>>
>>>>>>>   Just update the copyright year in the TestFontFile.sh.
>>>>>>>
>>>>>>>  Thanks,
>>>>>>>  Alexandr.
>>>>>>>
>>>>>>> On 3/27/2015 8:33 PM, pooja chopra wrote:
>>>>>>>> Hello,
>>>>>>>> Please review a fix for issue :
>>>>>>>> 8076151 [TEST_BUG] Test 
>>>>>>>> java/awt/FontClass/CreateFont/fileaccess/FontFile.java fails
>>>>>>>> Test bug fix.
>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8076151
>>>>>>>> The webrev is: 
>>>>>>>> http://cr.openjdk.java.net/~kshefov/8076151/webrev.01/
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Pooja
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]