[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-swing-dev
Subject:    <Swing Dev> [8] Review request for 7170657: [macosx] There seems to be no keyboard/mouse action to s
From:       pavel.porvatov () oracle ! com (Pavel Porvatov)
Date:       2012-07-16 9:42:36
Message-ID: 5003E20C.9010705 () oracle ! com
[Download RAW message or body]

Hi Sergey,

Looks good for me.

Regards, Pavel
> Hi, Pavel.
> Thanks for review. See comments inline
> 12.07.2012 20:26, Pavel Porvatov wrote:
>> Hi Sergey,
>>
>> The fix looks good. Could you please remove unnecessary code from the 
>> test like:
>>
>> 1. @run main/othervm bug7170657
> done
>> 2. The "FAILED" field: you can throw exception from the "fail" method
> In this case we skip part of the test. Useful for debug.
>> 3. What is the reason to use final here: "public final class"?
> I do not think that someone will want to be inherited from it. I just 
> make all classes final by default.
>
> New version of the fix:
> http://cr.openjdk.java.net/~serb/7170657/webrev.01/
>>
>> Regards, Pavel
>>> Hi Everyone,
>>> Please review the fix.
>>> Bug in SwingUtilities.convertMouseEvent().This method does not 
>>> convert extended state of the event.
>>>
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170657
>>> Webrev can be found at: 
>>> http://cr.openjdk.java.net/~serb/7170657/webrev.00
>>>
>>
>
>


[prev in list] [next in list] [prev in thread] [next in thread]