[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-sound-dev
Subject:    Re: RFR: 8316003: Update FileChooserSymLinkTest.java to HTML instructions [v4]
From:       Alexey Ivanov <aivanov () openjdk ! org>
Date:       2023-10-25 11:30:55
Message-ID: mboOeDvGzEWwat6hiozLzSC-DBJCH1NOeCHcXgK811o=.d5162179-ca15-4522-9b26-c27c233eb1da () github ! com
[Download RAW message or body]

> To demonstrate the functionality of HTML formatting in `PassFailJFrame`, I updated \
> the instructions for the \
> `test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java` test. The commands \
> to create the symbolic links are marked up with monospace font, which makes them \
> stand out. The test instructions for single- and multi-selection are emphasised \
> with bold text. 
> This change depends on #15660 and \
> [JDK-8294158](https://bugs.openjdk.org/browse/JDK-8294158).

Alexey Ivanov has updated the pull request with a new target base due to a merge or a \
rebase. The pull request now contains eight commits:

 - Merge master
 - Amend indentation of nested <li> elements
 - Revert "Revert changes to FileChooserSymLinkTest.java"
   
   This reverts commit 7753b3f3e2d3a0df5fde672ad41833b6a9c6e247.
 - Wrap createUI call
   
   It reverts the accidental change where I unwrapped call to createUI
 - Revert changes to FileChooserSymLinkTest.java
 - Refactor configuration of a text component for instructions
   
   Each text component (JTextArea or JEditorPane) are configured
   in its own dedicated method. This avoids unnecessary type casts.
 - Improve instruction formatting
 - Enable HTML display if instructions start with <html>
   
   Instructions for FileChooserSymLinkTest are rendered in HTML.

-------------

Changes: https://git.openjdk.org/jdk/pull/15661/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15661&range=03
  Stats: 43 lines in 1 file changed: 13 ins; 0 del; 30 mod
  Patch: https://git.openjdk.org/jdk/pull/15661.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15661/head:pull/15661

PR: https://git.openjdk.org/jdk/pull/15661


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic