[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-sound-dev
Subject:    Re: RFR: JDK-8289238: Refactoring changes to PassFailJFrame Test Framework [v4]
From:       Alexey Ivanov <aivanov () openjdk ! org>
Date:       2022-06-29 18:23:32
Message-ID: oCQRchm9SpCLX59maz68ggfm1nWyQLWCmbinLmXHmpU=.787bc3a2-6063-4cb4-b730-02fa4dd1baea () github ! com
[Download RAW message or body]

On Wed, 29 Jun 2022 17:17:11 GMT, Harshitha Onkar <honkar@openjdk.org> wrote:

> > Currently PassFailJFrame.positionTestFrame() and PassFailJFrame.addTestFrame() \
> > take Frame as input parameter, this has been changed to Window. 
> > Refactored the above method names to reflect the functionality & input parameter \
> > type - addTestWindow(), positionTestWindow()
> > 
> > Additionally added test fail reason to `forceFail()` to avoid NPE.
> > 
> > Benefits of the change -
> > 
> > - Since Window is a parent class, this would allow the test frame to be a \
> >                 Window/Frame/Dialog and not be restricted to a Frame.
> > - Code reusability - no need to have separate methods to manage Frame and Window
> > - Additionally it would allow proper clean-up of window and its container \
> > subclasses which are added to the PassFailJFrame.
> 
> Harshitha Onkar has updated the pull request incrementally with one additional \
> commit since the last revision: 
> minor change

Marked as reviewed by aivanov (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/9300


[prev in list] [next in list] [prev in thread] [next in thread]