[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-sound-dev
Subject:    Re: RFR: 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails [v2]
From:       Sergey Bylokhov <serb () openjdk ! java ! net>
Date:       2021-12-27 21:02:17
Message-ID: oN3535K2egKXu30j01jgkbvNyCr1FebFtyMZYo9WkP4=.40c36c3d-09f1-488b-ba97-92fc81d59187 () github ! com
[Download RAW message or body]

On Fri, 15 Oct 2021 11:09:26 GMT, Masanori Yano <myano@openjdk.org> wrote:

> > Could you please review the 7001973 fixes?
> > 
> > On Windows, CopyAreaOOB.java fails with a blank window. The cause of this problem \
> > is that paint() works one time only. Painting area is not guaranteed when showing \
> > a window. 
> > I think this behavior should be removed for purpose of this test (`@summary: \
> > Verifies that copyArea() works properly`). Also, this program uses a Robot, but \
> > implements waiting logic by itself. This logic should be replaced to Robot API. 
> > This fix works fine in Windows, so this test can be removed from ProblemList.txt. \
> > I don't have a Mac environment, so can someone please confirm that this fix will \
> > work on Mac?
> 
> Masanori Yano has updated the pull request with a new target base due to a merge or \
> a rebase. The incremental webrev excludes the unrelated changes brought in by the \
> merge/rebase. The pull request contains four additional commits since the last \
> revision: 
> - 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails
> - Merge branch 'master' of https://github.com/masyano/jdk into 7001973
> - 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails
> - 7001973: java/awt/Graphics2D/CopyAreaOOB.java fails

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/5491


[prev in list] [next in list] [prev in thread] [next in thread]