[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-sound-dev
Subject:    Re: <Sound Dev> [9] Review Request: 8168881 javax/sound/sampled/Clip/OpenNonIntegralNumberOfSamplefr
From:       Dan Rollo <danrollo () gmail ! com>
Date:       2016-11-02 18:21:04
Message-ID: 496A4E4E-DFD3-4724-A9DD-DB467EEC42F5 () gmail ! com
[Download RAW message or body]

+1

> On Nov 2, 2016, at 1:01 PM, Phil Race <philip.race@oracle.com> wrote:
> 
> +1
> 
> -phil
> 
> On 11/02/2016 09:56 AM, Sergey Bylokhov wrote:
> > Hello, Audio Guru.
> > 
> > Please review the fix for jdk9.
> > 
> > The new test(which was added recently) does not take into account that: if there \
> > is no any audio device the AudioSystem.getClip() can throw \
> > IllegalArgumentException, which is a little bit strange since there is no \
> > arguments in the getClip() method. 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8168881
> > Webrev can be found at: http://cr.openjdk.java.net/~serb/8168881/webrev.00
> > 
> 


[prev in list] [next in list] [prev in thread] [next in thread]