[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8320215: HeapDumper can use DumpWriter buffer during merge
From:       Serguei Spitsyn <sspitsyn () openjdk ! org>
Date:       2024-04-30 5:28:03
Message-ID: 34SEuGvhZ_HuwQuOOUZuHnD2dazgUV1RIyxYdlU3d4I=.3d0d6d2d-85e1-4632-8fa3-af475f4723c9 () github ! com
[Download RAW message or body]

On Fri, 19 Apr 2024 00:10:12 GMT, Alex Menkov <amenkov@openjdk.org> wrote:

> The fix updates HeapMerger to use writer buffer (no need to copy memory, also \
> writer buffer is 1MB instead of 4KB). Additionally fixed small issue in FileWriter \
> (looks like `ssize_t` instead of `size_t` is a typo, the argument should be \
> unsigned) 
> Testing: all HeapDump-related tests on Oracle supported platforms

Looks good.

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18850#pullrequestreview-2030232272


[prev in list] [next in list] [prev in thread] [next in thread]