[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling [v2]
From:       Serguei Spitsyn <sspitsyn () openjdk ! org>
Date:       2024-03-29 13:10:32
Message-ID: a9lWMAc5fqRcsoz1zjvNIpjCw_sRWWDH_p4npbQfSVA=.55894855-aece-4923-a966-180f58f3522b () github ! com
[Download RAW message or body]

On Fri, 29 Mar 2024 11:35:57 GMT, Andrei Pangin <apangin@openjdk.org> wrote:

> > This fix makes `AsyncGetCallTrace` reentrant and async-signal-safe.
> > Reentrancy is required in the cases when two or more profiling engines are \
> > running at the same time, e.g., when CPU and Wall clock profilers work together \
> > and therefore one profiler may interrupt another in the middle of getting a stack \
> > trace. 
> > Tested with async-profiler:
> > 
> > java -agentpath:/path/to/libasyncProfiler.so=start,event=cpu,interval=1ms,wall=1ms,file=profile.jfr
> > 
> 
> Andrei Pangin has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Rephrased comment about AsyncGetCallTrace reentrancy

Marked as reviewed by sspitsyn (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/18504#pullrequestreview-1968490876


[prev in list] [next in list] [prev in thread] [next in thread]