[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v11]
From:       Serguei Spitsyn <sspitsyn () openjdk ! org>
Date:       2024-03-29 4:08:37
Message-ID: 3ZAHb7N67_sF8KheEMD2Wb44QX0zgRjkALBx9sk0WhA=.85029ac8-8cda-4f4f-a204-332b4a67d0bf () github ! com
[Download RAW message or body]

On Wed, 27 Mar 2024 18:31:50 GMT, Kevin Walls <kevinw@openjdk.org> wrote:

> > Introduce the jcmd "VM.inspect" to implement access to detailed JVM object \
> > information. 
> > Not recommended for live production use.  Requires UnlockDiagnosticVMOptions and \
> > not included in jcmd help output, to remind us this is not a general-purpose \
> > customer-facing tool.
> 
> Kevin Walls has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Test more pointer types: compiled method and metadata.

test/hotspot/jtreg/serviceability/dcmd/vm/VMInspectTest.java line 117:

> 115:         output = executor.execute("VM.inspect -1");
> 116:         output.shouldContain("address not safe");
> 117: 

Nit: Just a suggestion to make the test more readable. Now when more test cases have \
                been added you may want to refactor it to call a separate method for \
                each sub-test.
E.g.: `testBaddAddresses()`, `testMisalignedAddress()`, \
`testCompiledMethodAddress()`, `testMetadataAddress()`, `testClassAddress()`, \
`testThreadAddress()`, etc.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17655#discussion_r1544038490


[prev in list] [next in list] [prev in thread] [next in thread]