[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8324799: Use correct extension for C++ test headers [v2]
From:       Kim Barrett <kbarrett () openjdk ! org>
Date:       2024-02-29 6:24:44
Message-ID: HOOsx2oFUwG3xuit0iTsW07FVeZEIIPk4rt1f6bPd64=.c83889a2-abbe-4781-aefd-5a024b531e9c () github ! com
[Download RAW message or body]

On Thu, 29 Feb 2024 00:16:28 GMT, Kim Barrett <kbarrett@openjdk.org> wrote:

> > Please review this change that renames some test .h files to .hpp.  These
> > files contain C++ code and should be named accordingly.  Some of them contain
> > uses of NULL, which we change to nullptr.
> > 
> > The renamed files are:
> > 
> > test/hotspot/jtreg/vmTestbase/nsk/share/aod/aod.h
> > test/hotspot/jtreg/vmTestbase/nsk/share/jni/jni_tools.h  
> > test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_tools.h
> > test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/JVMTITools.h
> > test/hotspot/jtreg/vmTestbase/nsk/share/native/nsk_tools.h 
> > 
> > test/lib/jdk/test/lib/jvmti/jvmti_thread.h
> > test/lib/jdk/test/lib/jvmti/jvmti_common.h
> > test/lib/native/testlib_threads.h 
> > 
> > The #include updates were performed mostly mechanically, and builds would fail
> > if there were mistakes.  The exception is test
> > test/hotspot/jtreg/serviceability/jvmti/FollowReferences/FieldIndices/libFieldIndicesTest.cpp,
> >  which was added after I'd done the mechanical update, so was updated by hand.
> > 
> > The copyright updates were similarly performed mechanically. All but a handful
> > of the including files have already had their copyrights updated recently,
> > likely as part of JDK-8324681.
> > 
> > Thus, the only "interesting" changes are to the renamed files.
> > 
> > Testing: mach5 tier1
> 
> Kim Barrett has updated the pull request incrementally with two additional commits \
> since the last revision: 
> - add Oracle copyright
> - fix busted copyright text

Thanks for all the reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18035#issuecomment-1970485416


[prev in list] [next in list] [prev in thread] [next in thread]