[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v4]
From:       Taizo Kurashige <duke () openjdk ! org>
Date:       2024-02-27 10:35:59
Message-ID: exAR7CupJJCp66-aJTtr_ktNV4eV821Rqeh42ygI7P4=.6a5f480b-76c5-4ea0-8a63-777db64ae70e () github ! com
[Download RAW message or body]

On Tue, 27 Feb 2024 08:06:18 GMT, Taizo Kurashige <duke@openjdk.org> wrote:

> > Hi,
> > 
> > I fixed the typos for JFR.start and JFR.dump.
> > Acconding to issue's description, there is some typo in JFR.stop documentation, \
> > but I couldn't find that. I confirmed that there is no such typo in this \
> > repository. So I thought there was no need to fix JFR.stop documentation. 
> > I confirmed that the fixes are reflected and that all of the jdk_jfr tests pass.
> > 
> > Could someone please review it?
> 
> Taizo Kurashige has updated the pull request with a new target base due to a merge \
> or a rebase. The incremental webrev excludes the unrelated changes brought in by \
> the merge/rebase. The pull request contains four additional commits since the last \
> revision: 
> - Merge branch 'openjdk:master' into JDK-8313710
> - 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump
> - 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump
> - 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump

Thanks for review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16413#issuecomment-1966250736


[prev in list] [next in list] [prev in thread] [next in thread]