[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8320005 :  Allow loading of shared objects with .a extension on AIX [v27]
From:       Suchismith Roy <sroy () openjdk ! org>
Date:       2024-02-27 8:31:15
Message-ID: 3Ijn-7dIJ9bNeJSj_YC1nZMLk5uuiigLhfIXBYngovY=.e15eb974-9144-4e28-8f9f-932b1c26d1e3 () github ! com
[Download RAW message or body]

On Tue, 27 Feb 2024 08:23:58 GMT, Suchismith Roy <sroy@openjdk.org> wrote:

> > src/hotspot/os/aix/os_aix.cpp line 1176:
> > 
> > > 1174:   if (result == nullptr && pointer_to_dot != nullptr && \
> > >                 strcmp(pointer_to_dot, old_extension) == 0) {
> > > 1175:       snprintf(pointer_to_dot, sizeof(old_extension), "%s", \
> > >                 new_extension);
> > > 1176:       result = dll_load_library(file_path, ebuf, ebuflen);
> > 
> > You should have adapted the indentation, too.
> 
> Which indentation ?

oh! to reduce the spaces

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1503821531


[prev in list] [next in list] [prev in thread] [next in thread]