[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8326433: Make libjdwp and libjava closeDescriptors() as static function [v2]
From:       Jiangli Zhou <jiangli () openjdk ! org>
Date:       2024-02-26 22:55:06
Message-ID: UWM3Dq34sLayrJl_LmkTqcus1JYmvzP9tjKBnyIXHLo=.4936f319-904e-4370-b18c-59e09d73a8fa () github ! com
[Download RAW message or body]

> Please help review this trivial fix for resolving `ld: error: duplicate symbol: \
> closeDescriptors` when static linking with both libjdwp and libjava, thanks.

Jiangli Zhou has updated the pull request incrementally with two additional commits \
since the last revision:

 - Address plummercj's comment and make forkedChildProcess static.
 - Revert src/java.base/unix/native/libjava/childproc.c and \
src/java.base/unix/native/libjava/childproc.h. Will handle those with JDK-8326714.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18013/files
  - new: https://git.openjdk.org/jdk/pull/18013/files/bb9e2791..3816d315

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18013&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18013&range=00-01

  Stats: 3 lines in 3 files changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/18013.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18013/head:pull/18013

PR: https://git.openjdk.org/jdk/pull/18013


[prev in list] [next in list] [prev in thread] [next in thread]