[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8324668: JDWP process management needs more efficient file descriptor handling [v7]
From:       Gerard Ziemski <gziemski () openjdk ! org>
Date:       2024-01-31 15:50:05
Message-ID: --dDlK42xbUCG_6_-GTYlNa6atGiA4SdIPERLHNtjqk=.76ca24ab-6f83-4644-a418-51d676f1b04b () github ! com
[Download RAW message or body]

On Wed, 31 Jan 2024 08:01:15 GMT, Jaikiran Pai <jpai@openjdk.org> wrote:

> > Can I please get a review of this change which proposes to address \
> > https://bugs.openjdk.org/browse/JDK-8324668? 
> > This change proposes to fix the issue in jdwp where when launching a child \
> > process (for the `launch=<cmd>` option), it iterates over an extremely large \
> > number of file descriptors to close each one of those. Details about the issue \
> > and the proposed fixed are added in a subsequent comment in this PR \
> > https://github.com/openjdk/jdk/pull/17588#issuecomment-1912256075. tier1, tier2 \
> > and tier3 testing is currently in progress with this change.
> 
> Jaikiran Pai has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Minor - fix alignment

Marked as reviewed by gziemski (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17588#pullrequestreview-1854147646


[prev in list] [next in list] [prev in thread] [next in thread]