[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8318895: Deoptimization results in incorrect lightweight locking stack [v3]
From:       David Holmes <dholmes () openjdk ! org>
Date:       2024-01-30 4:09:37
Message-ID: bqmKq7KWQXvdqdlwZpAL9iFIOu12QekMO3GnwLCuasM=.cfabcae0-4fca-4731-becf-50adc5ad05b4 () github ! com
[Download RAW message or body]

On Fri, 10 Nov 2023 10:41:16 GMT, Roman Kennke <rkennke@openjdk.org> wrote:

> > See JBS issue for details.
> > 
> > I basically:
> > - took the test-modification and turned it into its own test-case
> > - added test runners for lightweight- and legacy-locking, so that we keep testing \
> >                 both, no matter what is the default
> > - added Axels fix (mentioned in the JBS issue) with the modification to only \
> > inflate when exec_mode == Unpack_none, as explained by Richard. 
> > Testing:
> > - [x] EATests.java
> > - [x] tier1
> > - [x] tier2
> 
> Roman Kennke has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Update test/jdk/com/sun/jdi/EATests.java
> 
> Co-authored-by: Richard Reingruber <richard.reingruber@sap.com>

This PR calls code that expects to be passed a reference to the current thread, but \
is instead passed the `deoptee_thread`! See \
https://bugs.openjdk.org/browse/JDK-8324881

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16568#issuecomment-1916036852


[prev in list] [next in list] [prev in thread] [next in thread]